-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics: Adds missing info icon tooltips to scatterplot matrix option labels. #92626
Conversation
Pinging @elastic/ml-ui (:ml) |
@@ -57,6 +58,24 @@ const TOGGLE_OFF = i18n.translate('xpack.ml.splom.toggleOff', { | |||
|
|||
const sampleSizeOptions = [100, 1000, 10000].map((d) => ({ value: d, text: '' + d })); | |||
|
|||
interface OptionLabelWithIconItipProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra I
in OptionLabelWithIconItipProps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed in 247d514.
LGTM 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts.Dashboard Edit Panel can clone panelStandard Out
Stack Trace
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @walterra |
…plot matrix option labels. (elastic#92626) Adds missing info icon tooltips to scatterplot matrix option labels.
…plot matrix option labels. (elastic#92626) Adds missing info icon tooltips to scatterplot matrix option labels.
Summary
Part of #84420.
Adds missing info icon tooltips to scatterplot matrix option labels.
Checklist
Delete any items that are not applicable to this PR.
For maintainers