-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Step 1][TSVB] Enable dual mode
, support index patterns and strings
#92395
Conversation
1e59419
to
aa2610d
Compare
aa2610d
to
ebc220a
Compare
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @alexwizp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it locally and works fine 🙂
@elasticmachine run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, didn't check it out
…c#92395) Part of elastic#91367 Co-authored-by: Kibana Machine <[email protected]>
#92580) Part of #91367 Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
Part of #91367
Summary
Since we are working in parallel on removing
ReqFacade
(#92395), in order to avoid merge conflicts in the future, we need to merge this preparation step. What was done here:getSavedObjectsClient
was remove fromReqFacade
get_index_pattern.js
was typescriptified and moved to new locationgetIndexPatternObject
now works withindexPatternsService
instead ofgetSavedObjectsClient