Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step 1][TSVB] Enable dual mode, support index patterns and strings #92395

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Feb 23, 2021

Part of #91367

Summary

Since we are working in parallel on removing ReqFacade (#92395), in order to avoid merge conflicts in the future, we need to merge this preparation step. What was done here:

  1. getSavedObjectsClient was remove from ReqFacade
  2. get_index_pattern.js was typescriptified and moved to new location
  3. getIndexPatternObject now works with indexPatternsService instead of getSavedObjectsClient

@alexwizp alexwizp requested a review from sulemanof February 23, 2021 13:03
@alexwizp alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Feb 23, 2021
@alexwizp alexwizp requested a review from stratoula February 23, 2021 13:39
@elastic elastic deleted a comment from kibanamachine Feb 23, 2021
@alexwizp alexwizp marked this pull request as ready for review February 24, 2021 06:43
@alexwizp alexwizp requested a review from a team February 24, 2021 06:43
@alexwizp alexwizp self-assigned this Feb 24, 2021
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it locally and works fine 🙂

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't check it out

@alexwizp alexwizp merged commit d2abc03 into elastic:master Feb 24, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Feb 24, 2021
alexwizp added a commit that referenced this pull request Feb 24, 2021
#92580)

Part of #91367

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 25, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits)
  Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578)
  [Uptime] Search made easy (elastic#88581)
  [Lens] Stop requesting stats on Records field (elastic#92508)
  [APM] Correlations style polish in prep for release (elastic#92514)
  [Lens] Fix sorting undefined, null and NaN values (elastic#92575)
  Put environment back in uiFilters (elastic#92561)
  [Discover] Fix sorting by _score behavior (elastic#92132)
  Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290)
  [Usage Collection] Remove unused UI Metric APIs (elastic#91620)
  Fix timelion deprecation documentation links (elastic#92576)
  [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395)
  Fix text align in Safari (elastic#92374)
  [Actions][Doc] Clean up Actions README (elastic#91789)
  chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506)
  [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047)
  Revert "[build] Add task skips intended for partial builds (elastic#92076)"
  [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527)
  [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787)
  [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348)
  [DOCS] Updates refresh text in index pattern doc (elastic#92469)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants