Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Enable dual mode, support index patterns and strings #91367

Closed
stratoula opened this issue Feb 15, 2021 · 1 comment · Fixed by #92812
Closed

[TSVB] Enable dual mode, support index patterns and strings #91367

stratoula opened this issue Feb 15, 2021 · 1 comment · Fixed by #92812
Assignees
@alexwizp
Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:
TSVB right now doesn't work entirely with index patterns. Specifically, it allows the user to enter a string (which can be the index pattern title, an index, multiple indices, wildcards etc).

image

This has served us well so far but we have identified some cases that is not going to work well in the future. For example:

  • we will have to support runtime fields with a hacky way
  • if the index patterns work with non-unique pattern lists in the future, it will be impossible for TSVB to identify which index pattern the user wants to use (Imagine that the user has created 2 index patterns with the same pattern list but only one of them supports runtime fields).

For all the above we decided to enable a dual mode in TSVB. This means that we will keep the old implementation, meaning that we will be backwards compatible and the user will be able to create a visualization by giving a string but we will also give the user the ability to create a visualization from the index pattern.

What does it mean for the UI

The user will be able to choose an index pattern with a combobox. This mode (the indexpattern mode) will be the most obvious path for the user, meaning that the input string should be hidden or not so highlighted. We want our users to prefer to use index patterns instead of strings.
We also need to somehow inform the user that the old mechanism, the input string, will be deprecated on v8.

Future of the feature

On v8.0 we want to deprecate the old mechanism. This means that the visualizations that have been created with it will continue to be supported but the user won't be able to create new visualizations in this way. This means that the input string should be removed. On v9 we would like to prompt all our users to change their visualizations to work with index patterns and stop supporting the charts implemented with the legacy logic.

Runtime Fields

Runtime fields will be supported on TSVB but only for the visualizations that have been created with the indexpattern mode. In that way, runtime fields will be implemented properly and we won't block any future changes on the index patterns logic.
@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula mentioned this issue Feb 15, 2021
Closed
@flash1293 flash1293 mentioned this issue Feb 17, 2021
Closed
@stratoula stratoula mentioned this issue Feb 22, 2021
Closed
@alexwizp alexwizp self-assigned this Feb 23, 2021
@alexwizp alexwizp mentioned this issue Feb 23, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 23, 2021
@alexwizp
[TSVB] Enable dual mode, support index patterns and strings
ebc220a 
Part of elastic#91367
alexwizp added a commit that referenced this issue Feb 24, 2021
@alexwizp @kibanamachine
[TSVB] Enable dual mode, support index patterns and strings (#92395)
d2abc03 
Part of #91367

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Feb 24, 2021
@alexwizp @kibanamachine
[TSVB] Enable dual mode, support index patterns and strings (elasti…
69aed37 
…c#92395)

Part of elastic#91367

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this issue Feb 24, 2021
@alexwizp @kibanamachine
[TSVB] Enable dual mode, support index patterns and strings (#92395) (
6b5c289 
#92580)

Part of #91367

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@alexwizp alexwizp mentioned this issue Mar 16, 2021
Merged
@alexwizp alexwizp mentioned this issue Mar 31, 2021
Merged
@stratoula stratoula mentioned this issue Jun 2, 2021
Closed
@stratoula stratoula mentioned this issue Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
enhancement New value added to drive a business result Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TSVB] Enable dual mode, support index patterns and strings alexwizp/kibana
3 participants
@elasticmachine @stratoula @alexwizp