Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Markdown variables not working for empty labels #91838

Merged
merged 4 commits into from
Feb 23, 2021
Merged

[TSVB] Markdown variables not working for empty labels #91838

merged 4 commits into from
Feb 23, 2021

Conversation

VladLasitsa
Copy link
Contributor

Closes: #90756

Summary

When I have a split series by Terms on a field which contains an empty string, the markdown variables are not working properly.
So that fix it now we use (empty) instead of just empty string as in timeseries tab.

image

stratoula
stratoula approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested it locally and works fine 🙂

@VladLasitsa VladLasitsa self-assigned this Feb 19, 2021
@VladLasitsa VladLasitsa added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 labels Feb 19, 2021
@VladLasitsa VladLasitsa marked this pull request as ready for review February 19, 2021 13:58
@VladLasitsa VladLasitsa requested a review from a team February 19, 2021 13:58
@alexwizp
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTimeseries 470 471 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.7MB 1.7MB +740.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@stratoula
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@VladLasitsa VladLasitsa merged commit bfed81a into elastic:master Feb 23, 2021
@VladLasitsa VladLasitsa mentioned this pull request Feb 23, 2021
Merged
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Feb 23, 2021
@VladLasitsa @kibanamachine
[TSVB] Markdown variables not working for empty labels (elastic#91838)
c4d321f 
* Fix markdown for empty values

* Fix ci

* Fix eslint

Co-authored-by: Kibana Machine <[email protected]>
VladLasitsa added a commit that referenced this pull request Feb 24, 2021
@VladLasitsa @kibanamachine
[TSVB] Markdown variables not working for empty labels (#91838) (#92387)
adf9374 
* Fix markdown for empty values

* Fix ci

* Fix eslint

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@timroes timroes added the Feature:TSVB TSVB (Time Series Visual Builder) label Apr 26, 2021
@marius-dr marius-dr mentioned this pull request Apr 29, 2021
Closed
@alexwizp alexwizp mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Markdown variables not working for empty labels
5 participants
@VladLasitsa @alexwizp @kibanamachine @stratoula @timroes