Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] fix wrong labels, for values that are implicitly cast to false #103631

Merged
merged 3 commits into from
Jun 29, 2021
Merged

[TSVB] fix wrong labels, for values that are implicitly cast to false #103631

merged 3 commits into from
Jun 29, 2021

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 29, 2021 •
edited
Loading

Regression of: #91838

Summary

The aforementioned PR resulted in a regression in showing a values that could be implicitly casted to false. As a result instead of 0 and false user see (empty) which is not correct

Steps to reproduce:

  1. Install sample data sets
  2. Open TSVB and set kibana_sample_data_ecommerce index
  3. Configure aggregation as shown below:
    image
  4. Go to Top N tab

Actual result:

image

Expected result:

Instead of (empty) it should be 0

Additional information:

The same valid for Boolean fields

image

@alexwizp alexwizp requested a review from VladLasitsa June 29, 2021 10:14
@alexwizp alexwizp self-assigned this Jun 29, 2021
@alexwizp alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 v7.14.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 29, 2021
@elastic elastic deleted a comment from kibanamachine Jun 29, 2021
@elastic elastic deleted a comment from kibanamachine Jun 29, 2021
@alexwizp alexwizp marked this pull request as ready for review June 29, 2021 13:55
@alexwizp alexwizp requested a review from a team June 29, 2021 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula
stratoula approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexwizp thanx a ton for the finding and the quick fix. Code LGTM, I tested it locally and the regression is gone.

Feel free to merge in case of green ci

@alexwizp alexwizp removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 29, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 998.8KB 999.1KB +377.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp merged commit 0ba4153 into elastic:master Jun 29, 2021
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 29, 2021
@alexwizp
[TSVB] fix wrong labels, for values that are implicitly cast to false (…
d6b6132 
…elastic#103631)

* [TSVB] fix wrong labels, for values that are implicitly cast to false

* getMeaningfulValueOrEmpty  -> getValueOrEmpty

* fix CI
@alexwizp alexwizp mentioned this pull request Jun 29, 2021
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 29, 2021
@alexwizp
[TSVB] fix wrong labels, for values that are implicitly cast to false (…
a8d2aff 
…elastic#103631)

* [TSVB] fix wrong labels, for values that are implicitly cast to false

* getMeaningfulValueOrEmpty  -> getValueOrEmpty

* fix CI
# Conflicts:
#	src/plugins/vis_type_timeseries/public/application/components/lib/convert_series_to_vars.js
#	src/plugins/vis_type_timeseries/public/application/components/vis_with_splits.js
#	src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js
@alexwizp alexwizp mentioned this pull request Jun 29, 2021
Merged
alexwizp added a commit that referenced this pull request Jun 29, 2021
@alexwizp
[TSVB] fix wrong labels, for values that are implicitly cast to false (…
4b45fe5 
…#103631) (#103688)

* [TSVB] fix wrong labels, for values that are implicitly cast to false

* getMeaningfulValueOrEmpty  -> getValueOrEmpty

* fix CI
alexwizp added a commit that referenced this pull request Jun 29, 2021
@alexwizp
[TSVB] fix wrong labels, for values that are implicitly cast to false (…
6148bad 
…#103631) (#103689)

* [TSVB] fix wrong labels, for values that are implicitly cast to false

* getMeaningfulValueOrEmpty  -> getValueOrEmpty

* fix CI
# Conflicts:
#	src/plugins/vis_type_timeseries/public/application/components/lib/convert_series_to_vars.js
#	src/plugins/vis_type_timeseries/public/application/components/vis_with_splits.js
#	src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

Assignees

@alexwizp alexwizp

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @elasticmachine @kibanamachine @stratoula