[Discover] Fix toggling multi fields from doc view table #91121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
majagrubic
approved these changes
Feb 11, 2021
| @@ -54,6 +54,19 @@ export function DocViewTable({ | |||
| setFieldsWithParents(arr); | |||
| }, [indexPattern, hit]); | |||
|
|
|||
| const toggleColumn = useCallback( | |||
| (field: string) => { | |||
| if (onRemoveColumn && onAddColumn && Array.isArray(columns)) { | |||
There was a problem hiding this comment.
nit: we could just return early here if one of the conditions is not satisfied, so not the entire function would need to be inside an if-statement
There was a problem hiding this comment.
yes, agreed, it's really 🙈 , will improve
majagrubic
reviewed
Feb 11, 2021
| @@ -142,10 +146,12 @@ export function DocViewTable({ | |||
| displayUnderscoreWarning={displayUnderscoreWarning} | |||
| isCollapsed={isCollapsed} | |||
| isCollapsible={isCollapsible} | |||
| isColumnActive={Array.isArray(columns) && columns.includes(field)} | |||
| isColumnActive={Array.isArray(columns) && columns.includes(multiField)} | |||
There was a problem hiding this comment.
why do we need this check if columns is an array? it will always be at least an empty array, won't it?
There was a problem hiding this comment.
no, it can be undefined in the doc view, however, no need to check for an array here, since it's an array or undefined, good catch!
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 15, 2021
…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: [Discover] Fix toggling multi fields from doc view table (elastic#91121) [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991) skip flaky suite (elastic#86948) skip flaky suite (elastic#91191) Fix date histogram time zone for rollup index (elastic#90632) [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837) [Logs UI] Use useMlHref hook for ML links (elastic#90935) Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428) [APM] Darker shade for Error group details labels (elastic#91349) [Lens] Adjust new copy for 7.12 (elastic#90413) [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280) [Lens] Fix empty display name issue in XY chart (elastic#91132) [Lens] Improves error messages when in Dashboard (elastic#90668) [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546) [Lens] Improves ranking feature in Top values (elastic#90749) [ILM] Rollover min age tooltip and copy fixes (elastic#91110) # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Feb 15, 2021
kertal
added a commit
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue with adding multi fields from the doc viewer table (the parent field was added), and improves the rendering of the Multi field header (just by spanning it's container cell). So it no longer should look like this: