[Lens] Adjust new copy for 7.12 #90413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Lens
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dej611
reviewed
Feb 10, 2021
| @@ -227,7 +226,7 @@ const MovingAveragePopup = () => { | |||
| <p> | |||
| <FormattedMessage | |||
| id="xpack.lens.indexPattern.movingAverage.windowInitialPartial" | |||
| defaultMessage="For the initial part of the series the window is partial, until it reaches the requested number of items. For instance with a window size of 5:" | |||
| defaultMessage="The window is partial until it reaches the requested number of items. For example, with a window size of 5:" | |||
There was a problem hiding this comment.
The initial part was added to mark the specific case. Not a deal breaker for me, but check with @wylieconlon if he's ok with the change (he proposed the first version)
dej611
approved these changes
Feb 10, 2021
KOTungseth
approved these changes
Feb 10, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Feb 15, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 15, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 15, 2021
…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: [Discover] Fix toggling multi fields from doc view table (elastic#91121) [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991) skip flaky suite (elastic#86948) skip flaky suite (elastic#91191) Fix date histogram time zone for rollup index (elastic#90632) [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837) [Logs UI] Use useMlHref hook for ML links (elastic#90935) Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428) [APM] Darker shade for Error group details labels (elastic#91349) [Lens] Adjust new copy for 7.12 (elastic#90413) [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280) [Lens] Fix empty display name issue in XY chart (elastic#91132) [Lens] Improves error messages when in Dashboard (elastic#90668) [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546) [Lens] Improves ranking feature in Top values (elastic#90749) [ILM] Rollover min age tooltip and copy fixes (elastic#91110) # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts
flash1293
added a commit
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @gchaps , this PR updates the copy introduced for 7.12