-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Ensure Elasticsearch parts of Stack Monitoring work with metricbeat-*
indices
#90838
Closed
chrisronline
wants to merge
76
commits into
elastic:master
from
chrisronline:monitoring/ecs_final_es
Closed
[Monitoring] Ensure Elasticsearch parts of Stack Monitoring work with metricbeat-*
indices
#90838
chrisronline
wants to merge
76
commits into
elastic:master
from
chrisronline:monitoring/ecs_final_es
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
changed the title
[Monitoring]
[Monitoring] Ensure Elasticsearch parts of Stack Monitoring work with Mar 1, 2021
metricbeat-*
indices
Closing in favor of a feature branch in the elastic repo: #96205 |
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / jest / Jest Tests.x-pack/plugins/monitoring/server/lib/metrics.Metrics should export metric objects that match a snapshotStandard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/index_detail_mb·js.Monitoring app Elasticsearch index detail mb Active Indices "before all" hook for "should have an index summary with green status index with full shard allocation"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/monitoring/elasticsearch/overview_mb·js.Monitoring app Elasticsearch overview mb "before all" hook for "should have an Elasticsearch Cluster Summary Status with correct info"Standard Out
Stack Trace
and 1 more failures, only showing the first 3. Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #73864
Relates to elastic/beats#24427
This PR is meant to update all existing Stack Monitoring UI code to correctly work off
metricbeat-*
and.monitoring-*
indices for Elasticsearch-related areas of code. It is an extension of #88212 as it identifies the fields missed by actually using a working Metricbeat module (previously, we had to mock the output of the module which was error-prone).This effort is hard to guarantee 100% completion because we need to ensure every part of the front-end works properly with both data sets. We have two main ways to test this:
The main issue with 2 is that our existing functional test suites use archive data which is in
.monitoring-*
indices so they aren't very helpful in ensuring themetricbeat-*
data path works (but are helpful in determining the.monitoring-*
data path still does work) so I did some work to build archive data usingmetricbeat-*
indices.This work was done in several parts:
Part 1: Write a script that identifies all known aliases that currently exist in the
metricbeat-*
indices and write it to a file: https://gist.github.com/chrisronline/d24ec862efdb0cfa331c7ef785241116Part 2: Modify the
rebuild all
function of thees_archiver
script to build outmetricbeat-*
indices from the existing.monitoring-*
data archives, using the known aliases as well as some custom logic: https://github.com/elastic/kibana/pull/90838/files#diff-b0251a00b48f25e70b98d6741ae88948b22f9220a5ba5914aaaab465038da659 (This script is ran like:node ../scripts/es_archiver.js rebuild-all
)Part 3: Duplicate existing test suites and use the newly created archives based off
metricbeat-*
indices: https://github.com/elastic/kibana/pull/90838/files#diff-36d8e173c4e5a530dd9d5d68faca3cfd3f69f3803f80efda74c1f8bc562f033bNote: elastic/elasticsearch#71233 needs to be merged before all functional test will consistently pass