[Monitoring] Convert Elasticsearch-related server files that read from _source to typescript #88212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
changed the title
5 tasks
chrisronline
added
8.0.0
release_note:skip
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
chrisronline
force-pushed
the
monitoring/ecs_es
branch
from
69eddc7 to
1e1cc03
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #84370
This PR updates a couple source files used for Elasticsearch monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864
This one is the biggest and some of the fields added to the type definition were sourced directly from UI files (such as https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/directives/elasticsearch/ml_job_listing/index.js#L62). I don't have a ton of certainty this is a fool-proof method, but I'm hoping we can find any missing items either through this PR, or when we get the final PR set up on the beats side (which will be easier to test because that PR will cause Metricbeat to only index the fields we told them to)