[SearchSource] Combine sort and parent fields when serializing #89808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
ppisljar
reviewed
Feb 1, 2021
| @@ -49,6 +49,10 @@ function normalize( | |||
| } | |||
| } | |||
|
|
|||
| // FIXME: for unknown reason on the server this setting is serialized | |||
There was a problem hiding this comment.
can we create an issue for this and link it here ?
|
@elasticmachine merge upstream |
mattkime
approved these changes
Feb 1, 2021
|
@elasticmachine merge upstream |
|
Note there has been one small change since this PR was reviewed: eef541c |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 2, 2021
…ic#89808) * [SearchSource] Combine sort and parent fields when serializing * fix docs * add link to issue ; * fix destructive recursion Co-authored-by: Kibana Machine <[email protected]>
16 tasks
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Feb 2, 2021
…-ml-jobs * 'master' of github.com:elastic/kibana: (254 commits) [Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (elastic#89927) Skip test for cloud (elastic#89450) [Fleet] Fix duplicate data streams being shown in UI (elastic#89812) Bump package dependencies (elastic#90034) [App Search] DRY helper for encoding/decoding routes that can have special characters in params (elastic#89811) TypeScript project references for Observability plugin (elastic#89320) [SearchSource] Combine sort and parent fields when serializing (elastic#89808) Made imports static (elastic#89935) [ml] migrate file_data_visualizer/import route to file_upload plugin (elastic#89640) [Discover] Adapt default column behavior (elastic#89826) Round start and end values (elastic#89030) Rename getProxyAgents to getCustomAgents (elastic#89813) [Form lib] UseField `onError` listener (elastic#89895) [APM] use latency sum instead of avg for impact (elastic#89990) migrate more core-owned plugins to tsproject ref (elastic#89975) [Logs UI] Load <LogStream> entries via async searches (elastic#86899) [APM] Abort browser requests when appropriate (elastic#89557) [Alerting] Allow user to select existing connector of same type when fixing broken connector (elastic#89062) [Data Table] Use shared CSV export mechanism (elastic#89702) chore(NA): improve logic check when installing Bazel tools (elastic#89634) ...
tsullivan
added a commit
that referenced
this pull request
Feb 2, 2021
… (#90046) * [SearchSource] Combine sort and parent fields when serializing * fix docs * add link to issue ; * fix destructive recursion Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a step towards making CSV Export pass a serialized SearchSource when requesting to generate a CSV report.
Previously, calling
getSerializedFieldswould return just the fields of the SearchSource instance, and doesn't reference any parent search source.In this PR, passing
truetogetSerializedFieldswill reference all fields of the parent search sources by recursively nagivating up the hierarchy.Another issue solved in this PR is that the
sortfield of a search source needed special deserialization so that it can be part of the serialized fields.Checklist
Delete any items that are not applicable to this PR.
For maintainers