[SearchSource] Investigate why sort options is a string that needs to be parsed

[tsullivan]

This is a follow-up issue regarding

kibana/src/plugins/data/common/search/search_source/normalize_sort_request.ts

Line 31 in 8a8028e

defaultSortOptions: any

The defaultSortOptions object should always be correctly typed. Somewhere before the data reaches this function, it becomes a serialized string that needs to be re-converted into an object with JSON.parse.

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[tsullivan]

Same thing is happening in decorate_query.ts for queryStringOptions:

https://github.com/elastic/kibana/blob/7.11/src/plugins/data/common/es_query/es_query/decorate_query.ts#L23

[tsullivan]

The reason could be that defaultSortOptions and queryStringOptions are UI Settings. In the server-side context, UI Settings come back "raw" and serialized.

cc @ppisljar

[ppisljar]

hmm, if that is the case i think we should try to change the server side so it parses the uiSettings the same way we do on the client.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[tsullivan]

Cleaning up old technical debt issues. Let's close this as it doesn't need to be tracked. Let's get to this one if it comes up in any active work.