[Discover] Inline state modifying function to react #89543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-28-deangularize-state-functions
This was referenced Feb 3, 2021
46 tasks
…-28-deangularize-state-functions
kertal
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
1 task
|
@elasticmachine merge upstream |
…ithub.com:kertal/kibana into kertal-pr-2021-01-28-deangularize-state-functions
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
majagrubic
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Tested this in Chrome on Mac OSX for basic Discover functionality:
- adding/removing columns
- switching index patterns
- saving a search
- adding a search to dashboard
- zooming in on histogram
- adding/removing filters
All works as expected. I didn't dig too deep into code changes, as it's a lot of moving code around.
| @@ -752,65 +702,6 @@ function discoverController($route, $scope, Promise) { | |||
| return Promise.resolve(); | |||
| }; | |||
|
|
|||
| $scope.setSortOrder = function setSortOrder(sort) { | |||
| @@ -8,27 +8,16 @@ | |||
| hits="hits" | |||
| index-pattern="indexPattern" | |||
| minimum-visible-rows="minimumVisibleRows" | |||
| on-add-column="addColumn" | |||
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Feb 8, 2021
kertal
added a commit
that referenced
this pull request
Feb 8, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves several function from discover angular controller to react components. Improving memoizing and therefore improving performance.
Part of #86166
Checklist