Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Deangularize controller #86166

Closed
42 of 46 tasks
kertal opened this issue Dec 16, 2020 · 2 comments
Closed
42 of 46 tasks

[Discover] Deangularize controller #86166

kertal opened this issue Dec 16, 2020 · 2 comments
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Dec 16, 2020

Since the controller of angular is frequently edited, it is recommendable to keep on migrating step by step. We shouldn't migrate Angular router code for now, since also used by Discover context, whose controller needs also to be deangularized.

Functions and variables of $scope should be migrated to helpers to be used in the main react component

@kertal kertal added the Feature:Discover Discover Application label Dec 16, 2020
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Apr 27, 2021

PR work in progress : #96766

@timroes timroes closed this as completed Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants