corrected spy fullscreen mode #8844
Conversation
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
I tested this in the Dashboard and the Visualize app, and the fix works well! Expanding the spy panel to full size, and collapsing it again now works as expected.
I don't think we need the guard-clauses to check if $spyEl exists. Each vis-container should have both the spy panel and the visualization. I removed those if-statements and the fix continues to work. Did you run into any issues without them?
| @@ -76,13 +76,20 @@ uiModules | |||
|
|
|||
| let applyClassNames = function () { | |||
| let $visEl = getVisContainer(); | |||
| const $spyEl = getter('.visualize-spy-container')(); | |||
There was a problem hiding this comment.
what do you think about defining getSpyElement in a way getVisContainer is defined just for consistency reasons ?
There was a problem hiding this comment.
getSpyContainer would be more consistent though ;o)
|
im wondering the same @thomasneirynck is wondering .... left a small comment |
|
jenkins, test this |
|
@ppisljar @thomasneirynck The guard clauses were added only to account for the possibility of getter() returing undefined. I wrote that code a while back before doing this PR, so I am not 100% sure why I needed that check otherwise. I'll try without as well. |
|
@ppisljar @thomasneirynck ready for review |
|
LGTM |
|
thanks a lot for fixing this @scampi |
--------- **Commit 1:** corrected spy fullscreen mode * Original sha: a092f15 * Authored by Stéphane Campinas <[email protected]> on 2016-10-26T09:22:58Z **Commit 2:** removed guard-clauses * Original sha: 0403470 * Authored by Stéphane Campinas <[email protected]> on 2016-10-28T09:02:23Z
Ensures that expanding the spy panel takes up the full width/height of the container. Closes #8843. --------- **Commit 1:** corrected spy fullscreen mode * Original sha: a092f15 * Authored by Stéphane Campinas <[email protected]> on 2016-10-26T09:22:58Z **Commit 2:** removed guard-clauses * Original sha: 0403470 * Authored by Stéphane Campinas <[email protected]> on 2016-10-28T09:02:23Z
Ensures that expanding the spy panel takes up the full width/height of the container. Closes elastic#8843. --------- **Commit 1:** corrected spy fullscreen mode * Original sha: 7c208b94c47a5377753fb381030cd787c4bcc80c [formerly a092f15] * Authored by Stéphane Campinas <[email protected]> on 2016-10-26T09:22:58Z **Commit 2:** removed guard-clauses * Original sha: 1ed4ccf49d3bbc2734ba7633114221e9be49b8f3 [formerly 0403470] * Authored by Stéphane Campinas <[email protected]> on 2016-10-28T09:02:23Z Former-commit-id: 2fdf95a
close #8843