Backport PR #8844: corrected spy fullscreen mode

Ensures that expanding the spy panel takes up the full width/height of the container. Closes #8843. --------- **Commit 1:** corrected spy fullscreen mode * Original sha: a092f15 * Authored by Stéphane Campinas <[email protected]> on 2016-10-26T09:22:58Z **Commit 2:** removed guard-clauses * Original sha: 0403470 * Authored by Stéphane Campinas <[email protected]> on 2016-10-28T09:02:23Z
elastic · Oct 28, 2016 · 2fdf95a · 2fdf95a
1 parent 236557b
commit 2fdf95a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js
@@ -50,6 +50,7 @@ uiModules
 
       let getVisEl = getter('.visualize-chart');
       let getVisContainer = getter('.vis-container');
+      let getSpyContainer = getter('.visualize-spy-container');
 
       // Show no results message when isZeroHits is true and it requires search
       $scope.showNoResultsMessage = function () {
@@ -76,13 +77,16 @@ uiModules
 
       let applyClassNames = function () {
         let $visEl = getVisContainer();
+        const $spyEl = getSpyContainer();
         let fullSpy = ($scope.spy.mode && ($scope.spy.mode.fill || $scope.fullScreenSpy));
 
         $visEl.toggleClass('spy-only', Boolean(fullSpy));
+        $spyEl.toggleClass('only', Boolean(fullSpy));
 
         $timeout(function () {
           if (shouldHaveFullSpy()) {
             $visEl.addClass('spy-only');
+            $spyEl.addClass('only');
           };
         }, 0);
       };

diff --git a/src/ui/public/visualize/visualize.less b/src/ui/public/visualize/visualize.less
@@ -95,8 +95,8 @@ visualize-spy {
     margin-right: 5px;
   }
 
-  &.only {
-    .visualize-spy-container {
+  .visualize-spy-container {
+    &.only {
       height: auto;
     }
   }