Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error #88119

Merged
merged 3 commits into from
Jan 13, 2021
+2 −2
Merged

Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error #88119

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f197889
Unskipping test
ymao1 Jan 11, 2021
b68f696
Adding refresh before checking status
ymao1 Jan 12, 2021
eedd7c6
Merge branch 'master' of https://github.com/elastic/kibana into flaky…
ymao1 Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
await testSubjects.click('alertsTab');
}

// Failing: See https://github.com/elastic/kibana/issues/87105
describe.skip('alerts list', function () {
describe('alerts list', function () {
before(async () => {
await pageObjects.common.navigateToApp('triggersActions');
await testSubjects.click('alertsTab');
Expand Down Expand Up @@ -407,6 +406,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
).to.equal('Error found in 1 alert.');
});

await refreshAlertsList();
expect(await testSubjects.getVisibleText('totalAlertsCount')).to.be(
'Showing: 2 of 2 alerts.'
);
Expand Down