Fixes Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error #88119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
changed the title
gmmorris
approved these changes
Jan 13, 2021
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Jan 13, 2021
…ctional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error (elastic#88119) * Unskipping test * Adding refresh before checking status
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Jan 13, 2021
…ctional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error (elastic#88119) * Unskipping test * Adding refresh before checking status
ymao1
added a commit
that referenced
this pull request
Jan 13, 2021
…ctional_with_es_ssl/apps/triggers_actions_ui/alerts_list·ts - Actions and Triggers app alerts list should display total alerts by status and error banner only when exists alerts with status error (#88119) (#88166) * Unskipping test * Adding refresh before checking status Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87105
Summary
Based on the screenshot from the flaky test (seen in the issue), it seems like the alert list wasn't refreshed before counting the number of alerts with each status. Since the error banner can be seen, the
Test: Failingalert is (correctly) in an error state but since the alert list wasn't refreshed, it still showed pending. Added a refresh to get an up to date status. Ran it through the flaky test runner a few times and it seems to resolve this flaky test.