Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [App Search] Minor const cleanup (#87885) #87942

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[7.x] [App Search] Minor const cleanup (#87885) #87942

merged 1 commit into from
Jan 12, 2021

Conversation

cee-chen
Copy link
Contributor

Backports the following commits to 7.x:

@cee-chen
[App Search] Minor const cleanup (elastic#87885)
54c6d5d 
* DRY out repeated DOCUMENTS_TITLE

* Move temporary title const's in engine folder to their own respective folders

- might as well get it set up early + prevents us from forgetting to clean this up later

* Update engine nav & engine router files
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 920 935 +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.5MB 1.5MB -200.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 63f8fe4 into elastic:7.x Jan 12, 2021
@cee-chen cee-chen deleted the backport/7.x/pr-87885 branch January 12, 2021 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cee-chen @kibanamachine