Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Minor const cleanup #87885

Merged
merged 3 commits into from
Jan 11, 2021
Merged

Conversation

cee-chen
Copy link
Contributor

Summary

Minor cleanup PR. We have some temporary i18n constants hanging out in engine/constants.ts that I've opted to preemptively create folders+constants files for ahead of time. This should make new component folder changes a little less of a headache in the future, + it's less likely we'll forget to update/clean up engine/constants.ts as we go.

Checklist

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 11, 2021
@cee-chen cee-chen requested review from JasonStoltz and a team January 11, 2021 18:01
@cee-chen
Copy link
Contributor Author

NOTE TO SELF: this will have a merge conflict with #87752 (in analytics/index.ts) so either PR needs to be updated depending on which one is merged in first

@cee-chen cee-chen force-pushed the const-title-cleanup branch from 72ad74b to 1270762 Compare January 11, 2021 18:12
@cee-chen cee-chen force-pushed the const-title-cleanup branch from 1270762 to ef261bf Compare January 11, 2021 19:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1054 1069 +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.8MB 1.8MB -200.0B

History

  • 💔 Build #98001 failed 127076226e5f49ad1df5de971d327029696cee34
  • 💔 Build #97997 failed 72ad74be2f158a81ad80ca09bca50f94d0c2d27b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit cf086b6 into elastic:master Jan 11, 2021
@cee-chen cee-chen deleted the const-title-cleanup branch January 11, 2021 21:52
cee-chen pushed a commit that referenced this pull request Jan 12, 2021
* DRY out repeated DOCUMENTS_TITLE

* Move temporary title const's in engine folder to their own respective folders

- might as well get it set up early + prevents us from forgetting to clean this up later

* Update engine nav & engine router files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants