Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.11] chore(NA): move elastic-datemath from mocha into jest (#87351) #87545

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 6, 2021

Backports the following commits to 7.11:

* chore(NA): move from mocha to jest

* chore(NA): init changes on sinon replacement

* chore(NA): continue to use sinon for timer mocks

* docs(NA): explaining why we keep to use sinon on elastic datemath

* chore(NA): remove sinon from elastic-datemath
@mistic mistic added the backport label Jan 6, 2021
@mistic
Copy link
Member Author

mistic commented Jan 6, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -26.9KB

Distributable file count

id before after diff
default 47636 48403 +767
oss 27844 27845 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.0KB 162.1KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit be47e5b into elastic:7.11 Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants