chore(NA): move elastic-datemath from mocha into jest #87351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Jan 5, 2021
mattkime
approved these changes
Jan 6, 2021
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 6, 2021
* chore(NA): move from mocha to jest * chore(NA): init changes on sinon replacement * chore(NA): continue to use sinon for timer mocks * docs(NA): explaining why we keep to use sinon on elastic datemath * chore(NA): remove sinon from elastic-datemath
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Jan 6, 2021
* chore(NA): move from mocha to jest * chore(NA): init changes on sinon replacement * chore(NA): continue to use sinon for timer mocks * docs(NA): explaining why we keep to use sinon on elastic datemath * chore(NA): remove sinon from elastic-datemath
mistic
added a commit
that referenced
this pull request
Jan 6, 2021
* chore(NA): move from mocha to jest * chore(NA): init changes on sinon replacement * chore(NA): continue to use sinon for timer mocks * docs(NA): explaining why we keep to use sinon on elastic datemath * chore(NA): remove sinon from elastic-datemath Co-authored-by: Kibana Machine <[email protected]>
mistic
added a commit
that referenced
this pull request
Jan 6, 2021
* chore(NA): move from mocha to jest * chore(NA): init changes on sinon replacement * chore(NA): continue to use sinon for timer mocks * docs(NA): explaining why we keep to use sinon on elastic datemath * chore(NA): remove sinon from elastic-datemath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It completes the first item of #85513 as it moves away the
elastic-datemathtests from mocha into jest.