Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): move canvas plugin tests out of __tests__ folder #87519

Merged
merged 6 commits into from
Jan 6, 2021

Conversation

mistic
Copy link
Member

@mistic mistic commented Jan 6, 2021

It moves the second item of #85513 forward as it moves canvas tests out of tests folder into our common setup for tests run with jest.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.11.1 labels Jan 6, 2021
@mistic mistic requested a review from tylersmalley January 6, 2021 16:39
@mistic mistic requested a review from a team as a code owner January 6, 2021 16:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Jan 6, 2021

@elasticmachine merge upstream

Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I think my only thought here is maybe changing the name of the directory where the helpers live from helpers to test_helpers to avoid any confusion since the helpers won't be living in a parent __tests__ directory anymore

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47256 48029 +773

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 693775c into elastic:master Jan 6, 2021
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
…87519)

* chore(NA): move canvas plugin tests out of __tests__ folder

* chore(NA): fix types import on fixtures

* chore(NA): rename helpers to test_helpers

Co-authored-by: Kibana Machine <[email protected]>
mistic added a commit to mistic/kibana that referenced this pull request Jan 6, 2021
…87519)

* chore(NA): move canvas plugin tests out of __tests__ folder

* chore(NA): fix types import on fixtures

* chore(NA): rename helpers to test_helpers

Co-authored-by: Kibana Machine <[email protected]>
@mistic
Copy link
Member Author

mistic commented Jan 6, 2021

7.x/7.12: a1862ca
7.11/7.11.1: 97b7ca8

mistic added a commit that referenced this pull request Jan 7, 2021
…87587)

* chore(NA): move canvas plugin tests out of __tests__ folder

* chore(NA): fix types import on fixtures

* chore(NA): rename helpers to test_helpers

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
mistic added a commit that referenced this pull request Jan 7, 2021
…87588)

* chore(NA): move canvas plugin tests out of __tests__ folder

* chore(NA): fix types import on fixtures

* chore(NA): rename helpers to test_helpers

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants