-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): move canvas plugin tests out of __tests__ folder #87519
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I think my only thought here is maybe changing the name of the directory where the helpers live from helpers
to test_helpers
to avoid any confusion since the helpers won't be living in a parent __tests__
directory anymore
…ana into move-canvas-from-tests-folder
💚 Build SucceededMetrics [docs]Distributable file count
History
To update your PR or re-run it, just comment with: |
…87519) * chore(NA): move canvas plugin tests out of __tests__ folder * chore(NA): fix types import on fixtures * chore(NA): rename helpers to test_helpers Co-authored-by: Kibana Machine <[email protected]>
…87519) * chore(NA): move canvas plugin tests out of __tests__ folder * chore(NA): fix types import on fixtures * chore(NA): rename helpers to test_helpers Co-authored-by: Kibana Machine <[email protected]>
…87587) * chore(NA): move canvas plugin tests out of __tests__ folder * chore(NA): fix types import on fixtures * chore(NA): rename helpers to test_helpers Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…87588) * chore(NA): move canvas plugin tests out of __tests__ folder * chore(NA): fix types import on fixtures * chore(NA): rename helpers to test_helpers Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
It moves the second item of #85513 forward as it moves canvas tests out of tests folder into our common setup for tests run with jest.