Also reset engineName and engineNotFound on clearEngine (#87259)

elastic · Jan 6, 2021 · 8c74bb3 · 8c74bb3
1 parent bd91c16
commit 8c74bb3
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/...s/enterprise_search/public/applications/app_search/components/engine/engine_logic.test.ts b/...s/enterprise_search/public/applications/app_search/components/engine/engine_logic.test.ts
@@ -136,6 +136,18 @@ describe('EngineLogic', () => {
         });
       });
 
+      describe('engineName', () => {
+        it('should be reset to an empty string', () => {
+          mount({ engineName: 'hello-world' });
+          EngineLogic.actions.clearEngine();
+
+          expect(EngineLogic.values).toEqual({
+            ...DEFAULT_VALUES,
+            engineName: '',
+          });
+        });
+      });
+
       describe('dataLoading', () => {
         it('should be set to true', () => {
           mount({ dataLoading: false });
@@ -147,6 +159,18 @@ describe('EngineLogic', () => {
           });
         });
       });
+
+      describe('engineNotFound', () => {
+        it('should be set to false', () => {
+          mount({ engineNotFound: true });
+          EngineLogic.actions.clearEngine();
+
+          expect(EngineLogic.values).toEqual({
+            ...DEFAULT_VALUES,
+            engineNotFound: false,
+          });
+        });
+      });
     });
 
     describe('initializeEngine', () => {

diff --git a/...lugins/enterprise_search/public/applications/app_search/components/engine/engine_logic.ts b/...lugins/enterprise_search/public/applications/app_search/components/engine/engine_logic.ts
@@ -64,12 +64,14 @@ export const EngineLogic = kea<MakeLogicType<EngineValues, EngineActions>>({
       '',
       {
         setEngineName: (_, { engineName }) => engineName,
+        clearEngine: () => '',
       },
     ],
     engineNotFound: [
       false,
       {
         setEngineNotFound: (_, { notFound }) => notFound,
+        clearEngine: () => false,
       },
     ],
   },