Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet][EPM] Restore es-storage-related commits #87183

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Jan 4, 2021

Summary

This restores the es-storage-related features which were removed by commit 70fbe91 (#85942)

@jfsiii jfsiii requested a review from a team as a code owner January 4, 2021 17:24
@jfsiii jfsiii requested a review from a team January 4, 2021 17:24
@jfsiii jfsiii requested a review from a team as a code owner January 4, 2021 17:24
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii self-assigned this Jan 4, 2021
@jfsiii jfsiii added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Jan 4, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 967.4KB 967.4KB +2.0B

Distributable file count

id before after diff
default 48026 48031 +5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 376.5KB 376.8KB +311.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
epm-packages 15 18 +3
epm-packages-assets - 8 +8
total +11

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfsiii
Copy link
Contributor Author

jfsiii commented Jan 4, 2021

thanks, @kevinlog !

@jfsiii jfsiii merged commit 52f6c7c into elastic:master Jan 4, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 87183 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 6, 2021
jfsiii pushed a commit that referenced this pull request Jan 7, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants