Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet][EPM] Revert es-storage-related commits #85942

Merged
merged 5 commits into from
Dec 15, 2020
Merged

[Fleet][EPM] Revert es-storage-related commits #85942

merged 5 commits into from
Dec 15, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Dec 15, 2020 •
edited
Loading

Summary

Since we will not land #85337 before feature-freeze, roll back the entire es-storage feature.

This reverts commits 81a340e (introduce es-storage) & 00c2e96 (use in file handler)

@jfsiii
Copy link
Contributor Author

jfsiii commented Dec 15, 2020

@elasticmachine merge upstream

@jfsiii jfsiii marked this pull request as ready for review December 15, 2020 14:13
@jfsiii jfsiii requested a review from a team as a code owner December 15, 2020 14:13
@jfsiii jfsiii requested a review from a team December 15, 2020 14:13
@jfsiii jfsiii requested a review from a team as a code owner December 15, 2020 14:13
@jfsiii
Copy link
Contributor Author

jfsiii commented Dec 15, 2020

@elasticmachine merge upstream

@jfsiii jfsiii self-assigned this Dec 15, 2020
@jfsiii jfsiii added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0 labels Dec 15, 2020
kevinlog
kevinlog approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@kevinlog kevinlog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if this affects anything, it would be the tests - so if everything passes, we should be good

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

skh
skh approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@skh skh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 when tests pass

@jfsiii
Copy link
Contributor Author

jfsiii commented Dec 15, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47241 47996 +755

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 377.1KB 376.8KB -311.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
epm-packages 18 15 -3
epm-packages-assets 8 - -8
total -11

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit ec4fbf2 into elastic:master Dec 15, 2020
@jfsiii jfsiii mentioned this pull request Dec 15, 2020
Merged
jfsiii pushed a commit that referenced this pull request Dec 15, 2020
@kibanamachine
[Fleet][EPM] Revert es-storage-related commits (#85942) (#86017)
70fbe91 
* Revert "[Fleet][EPM] Save installed package assets in ES (#83391)"

This reverts commit 81a340e.

* Revert 00c2e96

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@jfsiii jfsiii mentioned this pull request Jan 4, 2021
Merged
jfsiii pushed a commit that referenced this pull request Jan 4, 2021
Revert "[Fleet][EPM] Revert es-storage-related commits (#85942) (#86017…
52f6c7c 
…)" (#87183)

This reverts commit 70fbe91.
@jfsiii jfsiii mentioned this pull request Jan 6, 2021
Merged
jfsiii pushed a commit that referenced this pull request Jan 7, 2021
Revert "[Fleet][EPM] Revert es-storage-related commits (#85942) (#86017…
24dda99 
…)" (#87183) (#87593)

This reverts commit 70fbe91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@kevinlog kevinlog kevinlog approved these changes

@skh skh skh approved these changes

Assignees

@jfsiii jfsiii

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jfsiii @elasticmachine @kibanamachine @skh @kevinlog @paul-tavares