Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[logstash] remove "upgrade" functionality now that .logstash is a system index #87056

Merged
merged 5 commits into from
Dec 31, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 30, 2020

Closes #86038

In elastic/elasticsearch#66190 the .logstash index was migrated to a system index powered by an Elasticsearch plugin. This means that Kibana should no longer attempt to manage this index, which it seems is what this "upgrade" functionality is intended to do.

@spalger spalger added backport:skip This commit does not require backporting Feature:Logstash Pipelines Logstash Pipeline UI related Team:Logstash v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 30, 2020
@spalger
Copy link
Contributor Author

spalger commented Dec 30, 2020

Build https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/96432/ still have several errors because there are many errors with the snapshots currently, but it fixes all the issues related to the .logstash index specifically.

@spalger spalger marked this pull request as ready for review December 30, 2020 21:30
Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalger Thanks for the PR, it looks good. Base on the conclusion from #86038 (comment) ES manage system index upgrade, Kibana can remove upgrade checking

@spalger
Copy link
Contributor Author

spalger commented Dec 31, 2020

Ah, look at that. Sweet!

@spalger spalger merged commit 1da5fcf into elastic:master Dec 31, 2020
@spalger spalger deleted the fix/logstash-system-index-compat branch December 31, 2020 19:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logstash 61 54 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logstash 60.8KB 55.9KB -4.9KB

Distributable file count

id before after diff
default 47267 48025 +758

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logstash 25.9KB 25.6KB -313.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 4, 2021
…meline-component

* 'master' of github.com:elastic/kibana: (955 commits)
  remove SameSite:None workaround (elastic#86994)
  URL encoding for URL drilldown (elastic#86902)
  [Security Solution] Fix few styling issues (elastic#87045)
  [APM] Custom links can still be created with a read only user. (elastic#87089)
  prevent double update (elastic#86794)
  Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113)
  [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093)
  [APM] Add range query to service map trace walk (elastic#86631)
  [Discover] Deangularize navbar in context app (elastic#86353)
  skip "should schedule actions on legacy alerts" elastic#87010
  🍾 update notice text for 2021
  [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056)
  Enable prototype pollution protection in TSVB (elastic#85952)
  [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073)
  [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063)
  Adds more URLs to the docs links service (elastic#86972)
  Add missing backticks in reporting-settings.asciidoc (elastic#77979)
  [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050)
  [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033)
  [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
spalger added a commit that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Logstash Pipelines Logstash Pipeline UI related release_note:skip Skip the PR/issue when compiling release notes Team:Logstash v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing ES Promotion: logstash pipeline list route add button links to the empty pipeline editor
3 participants