Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL encoding for URL drilldown #86902

Merged
merged 9 commits into from
Jan 4, 2021
Merged

URL encoding for URL drilldown #86902

merged 9 commits into from
Jan 4, 2021

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Dec 23, 2020 •
edited
Loading

Summary

Closes #84650

  • Adds "Additional options" section
  • Moves "Open in new window" into "Additional options" section
  • Renames "Open in new tab" to "Open in new window" and "Enter URL template" to "Enter URL"
  • Adds "Encode URL" option
  • Adds encodeURIComponent and encodeURIQuery Handlebars helpers.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release note

In URL Drilldown "Open in new window" is now enabled by default. URL Drilldown now also has "Additional option" panel where URL encoding—which is enabled by default—can be disabled. Two new Handlebars helper functions were added to URL Drilldown: encodeURIComponent and encodeURIQuery, which allow user to manually encode parts of URL when URL encoding is disabled.

image

@streamich streamich marked this pull request as ready for review December 28, 2020 11:49
@streamich streamich requested a review from a team as a code owner December 28, 2020 11:49
@streamich streamich requested review from ppisljar and Dosant December 28, 2020 11:53
@streamich streamich added Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:enhancement review Team:AppServices v7.12.0 v8.0.0 labels Dec 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@streamich streamich changed the title Url encoding 2 URL Drilldown URL encoding Dec 28, 2020
@streamich streamich changed the title URL Drilldown URL encoding URL encoding for URL drilldown Dec 28, 2020
@streamich streamich mentioned this pull request Dec 28, 2020
Closed
8 tasks
@elastic-jb
Copy link

Both very useful changes. I like the clean organization as well. This looks great.

Dosant
Dosant approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested new encode checkbox and checked that open in a new window still works

@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47264 48024 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uiActionsEnhanced 267.3KB 270.0KB +2.6KB
urlDrilldown 53.9KB 54.1KB +155.0B
total +2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 5591e00 into elastic:master Jan 4, 2021
@streamich streamich mentioned this pull request Jan 4, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 4, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/pocish-ti…
7f12f76 
…meline-component

* 'master' of github.com:elastic/kibana: (955 commits)
  remove SameSite:None workaround (elastic#86994)
  URL encoding for URL drilldown (elastic#86902)
  [Security Solution] Fix few styling issues (elastic#87045)
  [APM] Custom links can still be created with a read only user. (elastic#87089)
  prevent double update (elastic#86794)
  Upgrade @hapi/hoek to revert hack introduced in hapi v20 upgrade (elastic#87113)
  [APM] Every time the new Header Icon is clicked it fetches data (elastic#87093)
  [APM] Add range query to service map trace walk (elastic#86631)
  [Discover] Deangularize navbar in context app (elastic#86353)
  skip "should schedule actions on legacy alerts" elastic#87010
  🍾 update notice text for 2021
  [logstash] remove "upgrade" functionality now that .logstash is a system index (elastic#87056)
  Enable prototype pollution protection in TSVB (elastic#85952)
  [Security Solution] add a consistent spelling of ES in Policy Response (elastic#87073)
  [SECURITY_SOLUTION][ENDPOINT] Delete Endpoint Policy List code (elastic#87063)
  Adds more URLs to the docs links service (elastic#86972)
  Add missing backticks in reporting-settings.asciidoc (elastic#77979)
  [test/functional_cors] 9000 is sometimes in use, make getPort random (elastic#87050)
  [Security Solution] Fix Timeline filter EuiSuperSelect styling (elastic#87033)
  [Lens] Fix duplicate suggestions on single-bucket charts (elastic#86996)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
streamich added a commit that referenced this pull request Jan 5, 2021
@streamich @kibanamachine
[7.x] URL encoding for URL drilldown (#86902) (#87143)
98485a5 
* URL encoding for URL drilldown (#86902)

* feat: 🎸 use EuiSwitch for "Open in new window" toggle

* feat: 🎸 add "URL encoding" option and "Additional options"

* feat: 🎸 make "Open in new window" true by default

* feat: 🎸 respect encoding config setting

* test: 💍 add encoding tests

* feat: 🎸 add URI encoding Handlebars helpers

* docs: ✏️ add URL encoding methods to URL Drilldown docs

Co-authored-by: Kibana Machine <[email protected]>

* test: 💍 align 7.x branch with master

Co-authored-by: Kibana Machine <[email protected]>
@Dosant Dosant mentioned this pull request Nov 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees
No one assigned
Labels
Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. release_note:enhancement review v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL Drilldown: encoding and "additional options"
5 participants
@streamich @elasticmachine @elastic-jb @kibanamachine @Dosant