Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy src/plugins/charts -> src/plugins/discover cyclic dependencies #86758

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Remove legacy src/plugins/charts -> src/plugins/discover cyclic dependencies #86758

merged 1 commit into from
Dec 22, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Dec 22, 2020 •
edited
Loading

Part of #84750

Just a removing src/plugins/charts -> src/plugins/discover from allowed cyclic dependencies

@alexwizp alexwizp requested review from stratoula and kertal December 22, 2020 12:20
@alexwizp alexwizp self-assigned this Dec 22, 2020
@alexwizp alexwizp added v7.11.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Dec 22, 2020
@alexwizp alexwizp marked this pull request as ready for review December 22, 2020 12:25
@alexwizp alexwizp requested a review from a team as a code owner December 22, 2020 12:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp added v7.12.0 and removed v7.11.0 labels Dec 22, 2020
stratoula
stratoula approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already pinged @kertal about this. From my understanding, there is no dependency so I approve it. But it would be good if also Matthias can confirm that

kertal
kertal reviewed Dec 22, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be safe to remove

@kertal kertal self-requested a review December 22, 2020 12:51
kertal
kertal approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me, but now approved

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47144 47904 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 57d3349 into elastic:master Dec 22, 2020
@alexwizp alexwizp mentioned this pull request Dec 22, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Dec 22, 2020
@alexwizp
Remove legacy src/plugins/charts -> src/plugins/discover cyclic depen…
ca69fe7 
…dencies (elastic#86758)

Part of elastic#84750
alexwizp added a commit that referenced this pull request Dec 22, 2020
@alexwizp
Remove legacy src/plugins/charts -> src/plugins/discover cyclic depen…
709e64c 
…dencies (#86758) (#86799)

Part of #84750
@alexwizp alexwizp mentioned this pull request Dec 29, 2020
Merged
alexwizp added a commit to alexwizp/kibana that referenced this pull request Dec 29, 2020
@alexwizp
Remove src/plugins/vis_default_editor -> src/plugins/visualizations c…
e001422 
…yclic dependencies

Part of elastic#86758
alexwizp added a commit that referenced this pull request Jan 11, 2021
@alexwizp @kibanamachine
Remove src/plugins/vis_default_editor -> src/plugins/visualizations c…
66c8b2a 
…yclic dependencies (#86988)

* Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies

Part of #86758

* Update agg_common_props.ts

* Schemas -> visualizations

* fix JEST

* make Schemas class private for visualizations plugin

* fix type error

* fix markdown app in visualize app

* remove visualizations from kibana.json's

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jan 11, 2021
@alexwizp @kibanamachine
Remove src/plugins/vis_default_editor -> src/plugins/visualizations c…
ca44ffd 
…yclic dependencies (elastic#86988)

* Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies

Part of elastic#86758

* Update agg_common_props.ts

* Schemas -> visualizations

* fix JEST

* make Schemas class private for visualizations plugin

* fix type error

* fix markdown app in visualize app

* remove visualizations from kibana.json's

Co-authored-by: Kibana Machine <[email protected]>
alexwizp added a commit that referenced this pull request Jan 11, 2021
@alexwizp @kibanamachine
Remove src/plugins/vis_default_editor -> src/plugins/visualizations c…
7e15ecf 
…yclic dependencies (#86988) (#87804)

* Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies

Part of #86758

* Update agg_common_props.ts

* Schemas -> visualizations

* fix JEST

* make Schemas class private for visualizations plugin

* fix type error

* fix markdown app in visualize app

* remove visualizations from kibana.json's

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@jbudz jbudz jbudz approved these changes

@kertal kertal kertal approved these changes

Assignees

@alexwizp alexwizp

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexwizp @elasticmachine @kibanamachine @kertal @jbudz @stratoula