Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (#86988) #87804

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

alexwizp
Copy link
Contributor

Backports the following commits to 7.x:

…yclic dependencies (elastic#86988)

* Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies

Part of elastic#86758

* Update agg_common_props.ts

* Schemas -> visualizations

* fix JEST

* make Schemas class private for visualizations plugin

* fix type error

* fix markdown app in visualize app

* remove visualizations from kibana.json's

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visualizations 153 154 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visDefaultEditor 301.0KB 301.3KB +232.0B
visTypeTable 154.1KB 154.0KB -188.0B
visTypeVislib 643.9KB 643.9KB +1.0B
visualizations 61.7KB 61.7KB +2.0B
total +47.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
regionMap 44.4KB 44.4KB -41.0B
tileMap 44.5KB 44.5KB -41.0B
visDefaultEditor 46.5KB 44.3KB -2.2KB
visTypeMetric 26.4KB 26.3KB -41.0B
visTypeTagcloud 19.0KB 18.9KB -16.0B
visTypeVislib 46.7KB 46.4KB -217.0B
visTypeXy 68.3KB 68.0KB -247.0B
visualizations 169.4KB 171.4KB +1.9KB
total -895.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 7e15ecf into elastic:7.x Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants