Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] Remove Add Alerts flyout onClose #85462

Merged
merged 6 commits into from
Dec 15, 2020
Merged

[Alerts] Remove Add Alerts flyout onClose #85462

merged 6 commits into from
Dec 15, 2020

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Dec 9, 2020 •
edited
Loading

Resolves #85211

Summary

Removes AlertAdd flyout on close instead of showing/hiding. This fixes the console error described in the issue, as well as aligning with how we now handle the Add Connector, Edit Connector and Edit Alert flyouts.

Checklist

Delete any items that are not applicable to this PR.

@ymao1 ymao1 changed the title Remove add alerts flyout after onClose [Alerts] Remove Add Alerts flyout onClose Dec 9, 2020
@ymao1 ymao1 self-assigned this Dec 9, 2020
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0 labels Dec 9, 2020
@ymao1 ymao1 marked this pull request as ready for review December 9, 2020 20:31
@ymao1 ymao1 requested review from a team as code owners December 9, 2020 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

YulNaumenko
YulNaumenko approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works as expected, no console errors now.

@botelastic botelastic bot added Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Dec 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@weltenwort weltenwort self-requested a review December 14, 2020 10:13
weltenwort
weltenwort approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra plugin changes LGTM

gmmorris
gmmorris suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I've been meaning to do this myself for ages!
Thanks for doing it. :)

Sadly, I think this has broken the alerts example.

If you start Kibana with the example plugins yarn start --run-examples --ssl and navigate to Developer Exampled -> Alerting and then click on Create Alert it blows up :(

@gmmorris
Copy link
Contributor

Yes! I've been meaning to do this myself for ages!
Thanks for doing it. :)

Sadly, I think this has broken the alerts example.

If you start Kibana with the example plugins yarn start --run-examples --ssl and navigate to Developer Exampled -> Alerting and then click on Create Alert it blows up :(

I take this back!
Looks like it's broken on Main.
I think it was broken by #84604

@ymao1
Copy link
Contributor Author

ymao1 commented Dec 14, 2020

@elasticmachine merge upstream

@gmmorris
Copy link
Contributor

Yes! I've been meaning to do this myself for ages!
Thanks for doing it. :)
Sadly, I think this has broken the alerts example.
If you start Kibana with the example plugins yarn start --run-examples --ssl and navigate to Developer Exampled -> Alerting and then click on Create Alert it blows up :(

I take this back!
Looks like it's broken on Main.
I think it was broken by #84604

I've merged #85774 which fixes this

@gmmorris
Merge branch 'master' into pr/85462
fa70d31 
* master: (66 commits)
  [Alerting] fixes broken Alerting Example plugin (elastic#85774)
  [APM] Service overview instances table (elastic#85770)
  [Security Solution] Unskip timeline creation Cypress test (elastic#85871)
  properly recognize enterprise licenses (elastic#85849)
  [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690)
  [TSVB] Fix functional tests flakiness and unskip them (elastic#85388)
  [Fleet] Change permissions for Fleet enroll role (elastic#85802)
  Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768)
  [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488)
  [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424)
  skip flaky suite (elastic#78553)
  License checks for alerts plugin (elastic#85649)
  skip flaky suite (elastic#84992)
  skip 'query return results valid for scripted field' elastic#78553
  Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919)
  [ML] More machine learning links in doc_links_service.ts (elastic#85365)
  Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652)
  Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859)
  Fix outdated jest snapshot
  [Maps] Surface on prem EMS (elastic#85729)
  ...
gmmorris
gmmorris approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +76.0B
infra 2.7MB 2.7MB +206.0B
triggersActionsUi 1.6MB 1.6MB -151.0B
uptime 1.0MB 1.0MB +110.0B
total +241.0B

Distributable file count

id before after diff
default 47237 47997 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 180.1KB 180.2KB +125.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit 853f30e into elastic:master Dec 15, 2020
ymao1 added a commit to ymao1/kibana that referenced this pull request Dec 15, 2020
@ymao1 @kibanamachine @gmmorris
[Alerts] Remove Add Alerts flyout onClose (elastic#85462)
dd358b8 
* Remove add alerts flyout after onClose

* Updating tests

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Gidi Meir Morris <[email protected]>
@ymao1 ymao1 mentioned this pull request Dec 15, 2020
Merged
ymao1 added a commit that referenced this pull request Dec 15, 2020
@ymao1 @kibanamachine @gmmorris
[Alerts] Remove Add Alerts flyout onClose (#85462) (#85966)
a73d98f 
* Remove add alerts flyout after onClose

* Updating tests

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Gidi Meir Morris <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Gidi Meir Morris <[email protected]>
@ymao1 ymao1 mentioned this pull request Dec 17, 2020
Merged
4 tasks
@ymao1 ymao1 deleted the alerting/remove-flyout-onclose branch February 4, 2021 15:24
@ymao1 ymao1 mentioned this pull request Mar 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@weltenwort weltenwort weltenwort approved these changes

@gmmorris gmmorris gmmorris approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@ymao1 ymao1

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting UI] Console error on open Alert create flyout.
8 participants
@ymao1 @elasticmachine @gmmorris @kibanamachine @sorenlouv @weltenwort @shahzad31 @YulNaumenko