-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 #84768
Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 #84768
Conversation
…e Kibana 7.10.0 Closes elastic#84191
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! On attached screens I see that there are no labels for splitted data. But it's related to: #84764
Pinging @elastic/kibana-app (Team:KibanaApp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tested locally, works as expected both for gauge and goal visualizations!
I noticed such a weird overlapping in gauge vis.. Are you able reproduce the same locally?
src/plugins/vis_type_vislib/public/vislib/visualizations/gauge_chart.js
I used kibana_sample_data_ecommerce
index, split by Terms
- category.keyword
.
And I actually expect to see 5 gauges of each category, but see only 2. Seems to be bug!
Could you please check? If it is, an issue is worth to be created!
@sulemanof I can't reproduce it locally @dziyanadzeraviankina thanx for this PR! It seems to work great but can you also add a functional test about this? It seems that we don't test filtering on gauge and it will be good to have it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanx @dziyanadzeraviankina for the functional test, it looks great now ❤️
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
* master: (66 commits) [Alerting] fixes broken Alerting Example plugin (elastic#85774) [APM] Service overview instances table (elastic#85770) [Security Solution] Unskip timeline creation Cypress test (elastic#85871) properly recognize enterprise licenses (elastic#85849) [SecuritySolution][Detections] Adds SavedObject persistence to Signals Migrations (elastic#85690) [TSVB] Fix functional tests flakiness and unskip them (elastic#85388) [Fleet] Change permissions for Fleet enroll role (elastic#85802) Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (elastic#84768) [Security Solution][Detections] Add alert source to detection rule action context (elastic#85488) [Discover] Don't display hide/show button for histogram when there's no time filter (elastic#85424) skip flaky suite (elastic#78553) License checks for alerts plugin (elastic#85649) skip flaky suite (elastic#84992) skip 'query return results valid for scripted field' elastic#78553 Allow action types to perform their own mustache variable escaping in parameter templates (elastic#83919) [ML] More machine learning links in doc_links_service.ts (elastic#85365) Removed Alerting & Event Log deprecated fields that should not be using (elastic#85652) Closes elastic#79995 by adding new tab in transaction details to show related trace logs. (elastic#85859) Fix outdated jest snapshot [Maps] Surface on prem EMS (elastic#85729) ...
…e Kibana 7.10.0 (elastic#84768) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes elastic#84191 * Add functional test to filtering on gauge
…e Kibana 7.10.0 (elastic#84768) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes elastic#84191 * Add functional test to filtering on gauge
…e Kibana 7.10.0 (#84768) (#85938) * Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 Closes #84191 * Add functional test to filtering on gauge Co-authored-by: Diana Derevyankina <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Closes #84191
Summary
Fixed filtering by click on split gauge visualizations:
Checklist
For maintainers