Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gauge, Goal] [Split Group] the label is not displayed for field types other than "number". #84764

Closed
alexwizp opened this issue Dec 2, 2020 · 7 comments
Assignees
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Feature:Gauge Vis Gauge and goal visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@alexwizp
Copy link
Contributor

alexwizp commented Dec 2, 2020

Kibana version:
master, 7.9??, 7.10

Describe the bug:
[Gauge, Goal] [Split Group] the label is not displayed for field types other than "number".

Steps to reproduce:

  1. Install a sample data and create a new Gauge visualization
  2. Add new Metric
    image
  3. Add new Bucket: aggregation: Terms, field type: Date
    image

Expected behavior:
I expect to see serialized value for label. Visualization cannot be used in its current view
image

For numbers it looks like:
image

Horizontal bar visualization draws labels in a better way for the same configuration:
image

@alexwizp alexwizp added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Dec 2, 2020
@alexwizp alexwizp changed the title [Gauge] [Split Group] the label is not displayed for field types other than "number". [Gauge, Goal] [Split Group] the label is not displayed for field types other than "number". Dec 2, 2020
@alexwizp
Copy link
Contributor Author

alexwizp commented Dec 2, 2020

Looks like we hide that labels if chart item has small size. I agree with this behavior for a single chart element, but it's pointless for split data.

Screen Recording 2020-12-02 at 5 22 35 PM

@timroes @stratoula any ideas?

@stratoula
Copy link
Contributor

stratoula commented Dec 3, 2020

Well yes I agree this visualization without any label can't be very helpful for the user. It happens on small screens though.

Screenshot 2020-12-03 at 11 12 47 AM

We could possibly make the labels text size responsive instead of hiding them but I would love the feedback from the design team. @miukimiu what do you think about it?

@timroes timroes added the Feature:ElasticCharts Issues related to the elastic-charts library label Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/datavis (Feature:ElasticCharts)

@timroes timroes added the Feature:Gauge Vis Gauge and goal visualization label Dec 10, 2020
@timroes
Copy link
Contributor

timroes commented Dec 10, 2020

cc @markov00 Since I don't think we should address that anymore in the vislib implementation and instead make sure Elastic Charts is behaving exactly the way we would want this to behave.

@markov00
Copy link
Member

@timroes the current implementation (that was released in @Alpha at the beginning of this year) actually scales the font depending on the chart size.

@timroes
Copy link
Contributor

timroes commented Dec 14, 2020

I'd close this issue then in favor of #56143, since I don't think we want to address that in the vislib implementation before switching over.

@timroes timroes closed this as completed Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ElasticCharts Issues related to the elastic-charts library Feature:Gauge Vis Gauge and goal visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants