[APM] Create new API's to return Latency and Throughput charts #85242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
cauemarcondes
commented
Dec 8, 2020
x-pack/plugins/apm/server/routes/transactions/get_throughput_charts/index.ts
Outdated
Show resolved
Hide resolved
cauemarcondes
force-pushed
the
apm-refactoring-transactions-charts
branch
from
b1cdf02 to
345e261
Compare
sorenlouv
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Overall it looks good but it's quite hard to review because there are so many changes. It looks like there is a good amount of test coverage added in this PR so I'll put my faith in that. Next time try to break it up so renames and re-orgs go in a separate PR.
.../plugins/apm/server/lib/transactions/get_latency_charts/mock_response/timeseries_response.ts
Outdated
Show resolved
Hide resolved
sorenlouv
reviewed
Dec 8, 2020
sorenlouv
reviewed
Dec 8, 2020
sorenlouv
reviewed
Dec 8, 2020
|
retest |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 10, 2020
* master: (53 commits) Fixing recovered instance reference bug (elastic#85412) Switch to new elasticsearch client for Visualizations (elastic#85245) Switch to new elasticsearch client for TSVB (elastic#85275) Switch to new elasticsearch client for Vega (elastic#85280) [ILM] Add shrink field to hot phase (elastic#84087) Add rolling-file appender to core logging (elastic#84735) [APM] Service overview: Dependencies table (elastic#83416) [Uptime ]Update empty message for certs list (elastic#78575) [Graph] Fix graph saved object references (elastic#85295) [APM] Create new API's to return Latency and Throughput charts (elastic#85242) [Advanced settings] Reset to default for empty strings (elastic#85137) [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761) [Fleet] Update agent listing for better status reporting (elastic#84798) [APM] enable 'sanitize_field_names' for Go (elastic#85373) Update dependency @elastic/charts to v24.4.0 (elastic#85452) Introduce external url service (elastic#81234) Deprecate disabling the security plugin (elastic#85159) [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355) [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API chore: 🤖 remove extraPublicDirs (elastic#85454) ...
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Dec 14, 2020
…ic#85242) * breaking /transactions/charts into /latency and /thoughput * adding unit tests * fixing UI * fixing i18n * addressing pr comments * fix api test * refactoring some stuff * addressing pr comments * addressing pr comments * fixing test Co-authored-by: Kibana Machine <[email protected]>
kibanamachine
removed
the
backport missing
cauemarcondes
added a commit
that referenced
this pull request
Dec 14, 2020
… (#85735) * breaking /transactions/charts into /latency and /thoughput * adding unit tests * fixing UI * fixing i18n * addressing pr comments * fix api test * refactoring some stuff * addressing pr comments * addressing pr comments * fixing test Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes
/transactions/chartsand creates two new APIs:/transactions/charts/latencyand/transactions/charts/throughput.