[Fleet] Update agent listing for better status reporting #84798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
nchaulet
commented
Dec 2, 2020
| if (suggestion.type === 'operator') { | ||
| return true; | ||
| } | ||
| esKuery.fromKueryExpression(value); |
There was a problem hiding this comment.
Added some validation of the kuery
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
commented
Dec 3, 2020
…e-agent-listing-status
|
@elasticmachine merge upstream |
jfsiii
approved these changes
Dec 9, 2020
Comment on lines
50
to
54
| const fields = ( | ||
| ((await data.indexPatterns.getFieldsForWildcard({ | ||
| pattern: INDEX_NAME, | ||
| })) as IFieldType[]) || [] | ||
| ).filter((field) => { |
There was a problem hiding this comment.
It took me a bit to parse this. WDYT about something like?
Suggested change
| const fields = ( | |
| ((await data.indexPatterns.getFieldsForWildcard({ | |
| pattern: INDEX_NAME, | |
| })) as IFieldType[]) || [] | |
| ).filter((field) => { | |
| const _fields: IFieldType[] = await data.indexPatterns.getFieldsForWildcard({ | |
| pattern: INDEX_NAME, | |
| }); | |
| const fields = (_fields || []).filter((field) => { |
| defaultMessage: 'Inactive', | ||
| }), | ||
| }, | ||
| ] as Array<{ label: string; status: string }>; |
There was a problem hiding this comment.
I know you didn't add this as Array<...>, but is it needed?
I believe TS can figure it out without any help, but if it does need it, could we try statusFilters: Array<...> instead of the type assertion?
There was a problem hiding this comment.
Yes TS figure it correctly going to remove the useless cast
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Dec 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 10, 2020
* master: (53 commits) Fixing recovered instance reference bug (elastic#85412) Switch to new elasticsearch client for Visualizations (elastic#85245) Switch to new elasticsearch client for TSVB (elastic#85275) Switch to new elasticsearch client for Vega (elastic#85280) [ILM] Add shrink field to hot phase (elastic#84087) Add rolling-file appender to core logging (elastic#84735) [APM] Service overview: Dependencies table (elastic#83416) [Uptime ]Update empty message for certs list (elastic#78575) [Graph] Fix graph saved object references (elastic#85295) [APM] Create new API's to return Latency and Throughput charts (elastic#85242) [Advanced settings] Reset to default for empty strings (elastic#85137) [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (elastic#83761) [Fleet] Update agent listing for better status reporting (elastic#84798) [APM] enable 'sanitize_field_names' for Go (elastic#85373) Update dependency @elastic/charts to v24.4.0 (elastic#85452) Introduce external url service (elastic#81234) Deprecate disabling the security plugin (elastic#85159) [FLEET] New Integration Policy Details page for use in Integrations section (elastic#85355) [Security Solutions][Detection Engine] Fixes one liner access control with find_rules REST API chore: 🤖 remove extraPublicDirs (elastic#85454) ...
nchaulet
added a commit
that referenced
this pull request
Dec 10, 2020
|
Hi @EricDavisX We have created 10 testcases and executed the same under Agent listing and status Test Run on 8.0.0-snapshot kibana cloud environment. Please let us know if anything is missing from our end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the agent list to better reflect agent status.
Implements the design defined here #81872
Details
EuiColorPaletteDisplayhealthy,unhealthy, ...I did some refacto to extra the search bar and filter from the agent list components (it started to be really too big in my opinion), we can still do more refacto, but I think it's a good tradeoff to keep this PR readable.
UI Change