Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Reposition form toggles #85143

Merged
merged 3 commits into from
Dec 8, 2020

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Dec 7, 2020

Summary

Move all ILM field toggles to the left side per ES UI form field guidelines.

CC @mdefazio

Screenshots

Before

Screenshot 2020-12-07 at 16 13 37

After

Warm phase fields
Screenshot 2020-12-07 at 16 03 19

Field with notifications
Screenshot 2020-12-07 at 16 05 00

Release note

We brought form fields in ILM more in line with ESUI standards.

@jloleysens jloleysens added release_note:enhancement Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 labels Dec 7, 2020
@jloleysens jloleysens requested a review from a team as a code owner December 7, 2020 15:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@mdefazio mdefazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
indexLifecycleManagement 137 138 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 239.8KB 242.1KB +2.3KB

Distributable file count

id before after diff
default 46902 47662 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Nice work!

I'm not sure if there's an open issue around this yet or not, but if I enable Set replicas and set a value, then go back to edit it and disable the toggle and save, it doesn't reset this field; it remains whatever value I set it the first time. I checked out master and I was able to reproduce there as well. Let me know if you'd like me to open up an issue for this!

@jloleysens jloleysens merged commit fac1f12 into elastic:master Dec 8, 2020
@jloleysens jloleysens deleted the ilm/form-toggles-reposition branch December 8, 2020 07:47
@jloleysens
Copy link
Contributor Author

Thanks for the review @alisonelizabeth ! I was able to reproduce the the bug and will create a PR to fix it shortly! This will not have been released but I will create an issue for tracking!

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 8, 2020
* merged toggleable field and described form component and moved toggle to left

* moved all toggles to left, renamed DescribedFormField -> DescribedFormRow and added new ToggleFieldWithDescribedFormRow component

* added new prop fieldNotices to render callouts in correct position on the left
@jloleysens
Copy link
Contributor Author

@alisonelizabeth issue for tracking: #85226

jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 8, 2020
…or-disable-searchable-snapshot-fields

* 'master' of github.com:elastic/kibana: (29 commits)
  HTTP CRUD+ API for Index Patterns (elastic#83576)
  Don't list packages in devDependencies already listed in dependencies (elastic#85120)
  Remove unused devDependencies (elastic#85121)
  [ILM] Reposition form toggles (elastic#85143)
  [APM] Make sure jest script can be run from anywhere (elastic#85111)
  Add EuiButtonEmptyTo components (elastic#85213)
  skip flaky suite (elastic#85216)
  skip flaky suite (elastic#83775)
  skip flaky suite (elastic#83774)
  skip flaky suite (elastic#83773)
  skip flaky suite (elastic#83793)
  skip flaky suite (elastic#85215)
  skip flaky suite (elastic#85217)
  [Usage Collection] Kibana Overview Page UI Metrics (elastic#81937)
  [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (elastic#84604)
  skip flaky suite (elastic#85208)
  [Security Solutions][Detection Engine] Fixes cypress errors by using latest signals mapping (elastic#84600)
  Small fixes to Kibana search bar (elastic#85079)
  Change link text to say Fleet (elastic#85083)
  [Metrics UI] Refactor Process List API to fetch only top processes (elastic#84716)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
jloleysens added a commit that referenced this pull request Dec 8, 2020
* merged toggleable field and described form component and moved toggle to left

* moved all toggles to left, renamed DescribedFormField -> DescribedFormRow and added new ToggleFieldWithDescribedFormRow component

* added new prop fieldNotices to render callouts in correct position on the left
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ILM release_note:enhancement Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants