Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to Kibana search bar #85079

Merged
merged 5 commits into from
Dec 7, 2020
Merged

Small fixes to Kibana search bar #85079

merged 5 commits into from
Dec 7, 2020

Conversation

snide
Copy link
Contributor

@snide snide commented Dec 4, 2020

Summary

  • Widens the width of the search bar to match the dropdown. It scales down on smaller screens.
  • Fixes some spacing issue that existed in the dropdown.

image

@snide snide requested review from ryankeairns and a team December 4, 2020 22:17
@snide snide requested a review from a team as a code owner December 4, 2020 22:17
@snide snide added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 4, 2020
ryankeairns
ryankeairns reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 600 looks a bit wide as the default, and I like @formgeist 's suggestion about animating the input.

I tinkered with this a bit and am liking a 400px to 600px width transition (upon focus) using a setting of transition: all $euiSnimSpeedFast. With all, you get the smoother feel when the background color and (I think) placeholder text color change as well.

search_anim

@snide
Copy link
Contributor Author

snide commented Dec 7, 2020

@ryankeairns want to just commit your changes? That looks good to me.

@snide
Copy link
Contributor Author

snide commented Dec 7, 2020

@ryankeairns your changes are merged. I made one small tweak to fix a breakpoint issue in ipad-sized screens. Tests updated, this should be good to go on green.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
globalSearchBar 24 35 +11

Distributable file count

id before after diff
default 46930 47691 +761

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 33.0KB 43.4KB +10.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@snide snide merged commit 1f75d0b into elastic:master Dec 7, 2020
@snide snide deleted the cleanup/search branch December 7, 2020 20:59
@snide snide mentioned this pull request Dec 7, 2020
Merged
@ryankeairns ryankeairns mentioned this pull request Dec 7, 2020
Closed
snide added a commit that referenced this pull request Dec 7, 2020
@snide @ryankeairns
Small fixes to Kibana search bar (#85079) (#85197)
fda14d0 
* Small fixes to Kibana search bar

* Animate width

* tweak for ipad breakpoint

Co-authored-by: Ryan Keairns <[email protected]>

Co-authored-by: Ryan Keairns <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/fix-hide-…
d04f61b 
…or-disable-searchable-snapshot-fields

* 'master' of github.com:elastic/kibana: (29 commits)
  HTTP CRUD+ API for Index Patterns (elastic#83576)
  Don't list packages in devDependencies already listed in dependencies (elastic#85120)
  Remove unused devDependencies (elastic#85121)
  [ILM] Reposition form toggles (elastic#85143)
  [APM] Make sure jest script can be run from anywhere (elastic#85111)
  Add EuiButtonEmptyTo components (elastic#85213)
  skip flaky suite (elastic#85216)
  skip flaky suite (elastic#83775)
  skip flaky suite (elastic#83774)
  skip flaky suite (elastic#83773)
  skip flaky suite (elastic#83793)
  skip flaky suite (elastic#85215)
  skip flaky suite (elastic#85217)
  [Usage Collection] Kibana Overview Page UI Metrics (elastic#81937)
  [Alerting UI] Replaced AlertsContextProvider with KibanaContextProvider and exposed components in API (elastic#84604)
  skip flaky suite (elastic#85208)
  [Security Solutions][Detection Engine] Fixes cypress errors by using latest signals mapping (elastic#84600)
  Small fixes to Kibana search bar (elastic#85079)
  Change link text to say Fleet (elastic#85083)
  [Metrics UI] Refactor Process List API to fetch only top processes (elastic#84716)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
@gsoldevila gsoldevila mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @kibanamachine @ryankeairns