Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature_directory directory and link #84464

Merged
merged 12 commits into from
Dec 14, 2020

Conversation

andreadelrio
Copy link
Contributor

@andreadelrio andreadelrio commented Nov 29, 2020

Summary

Fixes #83549
Removed the feature_directory directory and links to it that were included in the overview page footer.

Checklist

For maintainers

@andreadelrio andreadelrio requested a review from a team as a code owner November 29, 2020 20:09
@andreadelrio andreadelrio requested a review from a team November 29, 2020 20:09
@myasonik
Copy link
Contributor

myasonik commented Nov 29, 2020

Forgot to comment:

  • To resolve the internationalization check, you'll need pull out the strings you deleted from the translated files. Looks like this is: home.directory.tabs.allTitle, home.directory.tabs.dataTitle, home.directory.tabs.administrativeTitle, home.directory.tabs.otherTitle, kibana-react.pageFooter.appDirectoryButtonLabel
  • No idea what release note label to put on this... 🤷‍♂️

@andreadelrio andreadelrio added the release_note:skip Skip the PR/issue when compiling release notes label Nov 30, 2020
@ryankeairns ryankeairns self-requested a review November 30, 2020 18:07
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@alexfrancoeur
Copy link

Search wise, I think we're in a good spot for feature parity here. Are we planning to add the removal of the feature / app directory links to both the homepage and overview page in with the next release?

@ryankeairns
Copy link
Contributor

Search wise, I think we're in a good spot for feature parity here. Are we planning to add the removal of the feature / app directory links to both the homepage and overview page in with the next release?

Yes, remove from the footer of both pages.

@ryankeairns
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices code change LGTM.

@andreadelrio
Copy link
Contributor Author

@elasticmachine merge upstream

@ryankeairns
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
home 78 77 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 214.2KB 210.5KB -3.7KB

Distributable file count

id before after diff
default 47129 47889 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 132.3KB 131.6KB -692.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove app directory page and associated links
6 participants