Skip to content

Commit

Permalink
Remove feature_directory directory and link (#84464)
Browse files Browse the repository at this point in the history
  • Loading branch information
andreadelrio authored Dec 14, 2020
1 parent 5304e88 commit 12c40f7
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 235 deletions.
164 changes: 0 additions & 164 deletions src/plugins/home/public/application/components/feature_directory.js

This file was deleted.

4 changes: 0 additions & 4 deletions src/plugins/home/public/application/components/home_app.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import React from 'react';
import { I18nProvider } from '@kbn/i18n/react';
import PropTypes from 'prop-types';
import { Home } from './home';
import { FeatureDirectory } from './feature_directory';
import { TutorialDirectory } from './tutorial_directory';
import { Tutorial } from './tutorial/tutorial';
import { HashRouter as Router, Switch, Route } from 'react-router-dom';
Expand Down Expand Up @@ -78,9 +77,6 @@ export function HomeApp({ directories, solutions }) {
<Switch>
<Route path="/tutorial/:id" render={renderTutorial} />
<Route path="/tutorial_directory/:tab?" render={renderTutorialDirectory} />
<Route exact path="/feature_directory">
<FeatureDirectory addBasePath={addBasePath} directories={directories} />
</Route>
<Route exact path="/">
<Home
addBasePath={addBasePath}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jest.mock('../../app_links', () => ({
jest.mock('../../context', () => ({
useKibana: jest.fn().mockReturnValue({
services: {
application: { capabilities: { advancedSettings: { show: true } } },
application: { capabilities: { advancedSettings: { show: true, save: true } } },
notifications: { toast: { addSuccess: jest.fn() } },
},
}),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ interface Props {
path: string;
/** Callback function to invoke when the user wants to set their default route to the current page */
onSetDefaultRoute?: (event: MouseEvent) => void;
/** Callback function to invoke when the user wants to change their default route button is changed */
/** Callback function to invoke when the user wants to change their default route button is changed */
onChangeDefaultRoute?: (event: MouseEvent) => void;
}

Expand All @@ -51,9 +51,9 @@ export const OverviewPageFooter: FC<Props> = ({
} = useKibana<CoreStart>();

const { show, save } = application.capabilities.advancedSettings;
const isAdvancedSettingsEnabled = show && save;
if (!show && !save) return <></>;

const defaultRoutebutton = defaultRoute.includes(path) ? (
const defaultRouteButton = defaultRoute.includes(path) ? (
<RedirectAppLinks application={application}>
<EuiButtonEmpty
className="kbnOverviewPageFooter__button"
Expand Down Expand Up @@ -102,27 +102,7 @@ export const OverviewPageFooter: FC<Props> = ({
<footer className="kbnOverviewPageFooter">
<EuiFlexGroup justifyContent="spaceBetween">
<EuiFlexItem grow={false}>
<div>{isAdvancedSettingsEnabled ? defaultRoutebutton : null}</div>
</EuiFlexItem>

<EuiFlexItem grow={false}>
<div>
<RedirectAppLinks application={application}>
<EuiButtonEmpty
className="kbnOverviewPageFooter__button"
data-test-subj="allPlugins"
flush="both"
href={addBasePath('/app/home#/feature_directory')}
iconType="apps"
size="xs"
>
<FormattedMessage
id="kibana-react.pageFooter.appDirectoryButtonLabel"
defaultMessage="View app directory"
/>
</EuiButtonEmpty>
</RedirectAppLinks>
</div>
<div>{defaultRouteButton}</div>
</EuiFlexItem>
</EuiFlexGroup>
</footer>
Expand Down
6 changes: 0 additions & 6 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -1676,11 +1676,6 @@
"home.dataManagementDisclaimerPrivacyLink": "プライバシーポリシーをご覧ください。",
"home.dataManagementEnableCollection": " 収集を開始するには、 ",
"home.dataManagementEnableCollectionLink": "ここで使用状況データを有効にします。",
"home.directory.directoryTitle": "ディレクトリ",
"home.directory.tabs.administrativeTitle": "管理",
"home.directory.tabs.allTitle": "すべて",
"home.directory.tabs.dataTitle": "データの閲覧と可視化",
"home.directory.tabs.otherTitle": "その他",
"home.exploreButtonLabel": "独りで閲覧",
"home.exploreYourDataDescription": "すべてのステップを終えたら、データ閲覧準備の完了です。",
"home.header.title": "ホーム",
Expand Down Expand Up @@ -2784,7 +2779,6 @@
"kibana-react.kbnOverviewPageHeader.devToolsButtonLabel": "開発ツール",
"kibana-react.kbnOverviewPageHeader.stackManagementButtonLabel": "管理",
"kibana-react.mountPointPortal.errorMessage": "ポータルコンテンツのレンダリングエラー",
"kibana-react.pageFooter.appDirectoryButtonLabel": "アプリディレクトリを表示",
"kibana-react.pageFooter.changeDefaultRouteSuccessToast": "ランディングページが更新されました",
"kibana-react.pageFooter.changeHomeRouteLink": "ログイン時に別のページを表示",
"kibana-react.pageFooter.makeDefaultRouteLink": "これをランディングページにする",
Expand Down
6 changes: 0 additions & 6 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -1677,11 +1677,6 @@
"home.dataManagementDisclaimerPrivacyLink": "隐私声明。",
"home.dataManagementEnableCollection": " 要启动收集, ",
"home.dataManagementEnableCollectionLink": "请在此处启用使用情况数据。",
"home.directory.directoryTitle": "目录",
"home.directory.tabs.administrativeTitle": "管理",
"home.directory.tabs.allTitle": "全部",
"home.directory.tabs.dataTitle": "数据浏览和可视化",
"home.directory.tabs.otherTitle": "其他",
"home.exploreButtonLabel": "自己浏览",
"home.exploreYourDataDescription": "完成所有步骤后,您便可以随时浏览自己的数据。",
"home.header.title": "主页",
Expand Down Expand Up @@ -2785,7 +2780,6 @@
"kibana-react.kbnOverviewPageHeader.devToolsButtonLabel": "开发工具",
"kibana-react.kbnOverviewPageHeader.stackManagementButtonLabel": "管理",
"kibana-react.mountPointPortal.errorMessage": "呈现门户内容时出错",
"kibana-react.pageFooter.appDirectoryButtonLabel": "查看应用目录",
"kibana-react.pageFooter.changeDefaultRouteSuccessToast": "登陆页面已更新",
"kibana-react.pageFooter.changeHomeRouteLink": "登录时显示不同页面",
"kibana-react.pageFooter.makeDefaultRouteLink": "将此设为我的登陆页面",
Expand Down

0 comments on commit 12c40f7

Please sign in to comment.