[TSVB] Y-axis has number formatting not considering all series formatters in the group #83438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters in the group
DianaDerevyankina
added
bug
alexwizp
reviewed
Nov 16, 2020
src/plugins/vis_type_timeseries/public/application/components/vis_types/timeseries/vis.js
Outdated
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
alexwizp
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Code looks fine to me. @VladLasitsa could you please checkout and test it locally
stratoula
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
LGTM, testet it locally and bug is solved. Thank you @dziyanadzeraviankina 🙂
DianaDerevyankina
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Nov 18, 2020
…ters in the group (elastic#83438) * [TSVB] Y-axis has number formatting not considering all series formatters in the group * Replace check for percent with a check for same formatters in common * Remove unnecessary series check
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 18, 2020
…o-node-details * 'master' of github.com:elastic/kibana: (65 commits) update chromedriver dependency to 87 (elastic#83624) [TSVB] use new Search API for rollup search (elastic#83275) [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438) [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302) Add tag bulk action context menu (elastic#82816) [code coverage] adding plugin to flush coverage data (elastic#83447) [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413) Added eventBus to trigger and listen plotHandler event (elastic#83435) [Runtime fields] Editor phase 1 (elastic#81472) [Maps] Fix threshold alert issue resolving nested fields (elastic#83577) chore(NA): remove usage of unverified es snapshots (elastic#83589) [DOCS] Adds Elastic Contributor Program link (elastic#83561) Upgrade EUI to v30.2.0 (elastic#82730) Don't show loading screen during auto-reload (elastic#83376) Functional tests - fix esArchive mappings with runtime fields (elastic#83530) [deb/rpm] Create keystore after installation (elastic#76465) [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144) [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) ...
DianaDerevyankina
added a commit
to DianaDerevyankina/kibana
that referenced
this pull request
Nov 30, 2020
…ters in the group (elastic#83438) * [TSVB] Y-axis has number formatting not considering all series formatters in the group * Replace check for percent with a check for same formatters in common * Remove unnecessary series check
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83427
Summary
Added check to find out if all the series have the same formatters to set this type of formatter to Y-axis too.
Before Y-axis was displaying simple values although all the series had the same percent formatters:
Now in the same case, Y-axis has percent formatter too:
If another series with default number formatter is added, Y-axis shows simple values:
The same result for bytes:
Checklist
Delete any items that are not applicable to this PR.
For maintainers