-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timelion] Vertical cursor is not displayed across visualizations of a dashboard #83435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
Vertical cursor is not displayed across Timelion visualizations of a dashboad
Vertical cursor is not displayed across Timelion visualizations of a dashboard
Nov 17, 2020
stratoula
changed the title
Vertical cursor is not displayed across Timelion visualizations of a dashboard
[Timelion] Vertical cursor is not displayed across visualizations of a dashboard
Nov 17, 2020
stratoula
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, I have tested locally and it works fine. Thanx @VladLasitsa for this PR. Can you update the description of this PR and also I would like to backport it on 7.10.1 too
alexwizp
approved these changes
Nov 17, 2020
VladLasitsa
added
v7.10.1
v7.11.0
v8.0.0
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
Feature:Timelion
Timelion app and visualization
and removed
v7.11.0
labels
Nov 17, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Nov 18, 2020
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Nov 18, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 18, 2020
…o-node-details * 'master' of github.com:elastic/kibana: (65 commits) update chromedriver dependency to 87 (elastic#83624) [TSVB] use new Search API for rollup search (elastic#83275) [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438) [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302) Add tag bulk action context menu (elastic#82816) [code coverage] adding plugin to flush coverage data (elastic#83447) [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413) Added eventBus to trigger and listen plotHandler event (elastic#83435) [Runtime fields] Editor phase 1 (elastic#81472) [Maps] Fix threshold alert issue resolving nested fields (elastic#83577) chore(NA): remove usage of unverified es snapshots (elastic#83589) [DOCS] Adds Elastic Contributor Program link (elastic#83561) Upgrade EUI to v30.2.0 (elastic#82730) Don't show loading screen during auto-reload (elastic#83376) Functional tests - fix esArchive mappings with runtime fields (elastic#83530) [deb/rpm] Create keystore after installation (elastic#76465) [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144) [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) ...
VladLasitsa
added a commit
that referenced
this pull request
Nov 19, 2020
VladLasitsa
added a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Timelion
Timelion app and visualization
release_note:fix
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.10.1
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #82250
Summary
Added eventBus to trigger and listen plotHandler event so that we can set crosshair line in several instances of timelion.
Checklist
Delete any items that are not applicable to this PR.
For maintainers