Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate visualization:colorMapping advanced setting #83372

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Deprecate visualization:colorMapping advanced setting #83372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86806fa
Added deprecation for visualization:colorMapping
VladLasitsa Nov 13, 2020
ad796aa
Update text of deprecation
VladLasitsa Nov 20, 2020
24519a4
Merge remote-tracking branch 'upstream/master' into #82743
VladLasitsa Nov 20, 2020
ebea2d9
Update message
VladLasitsa Nov 20, 2020
b09d5d5
Delete from translations for re-translation
VladLasitsa Nov 20, 2020
5aac957
Merge branch 'master' into #82743
kibanamachine Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/management/advanced-options.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ of buckets to try to represent.

[horizontal]
[[visualization-colormapping]]`visualization:colorMapping`::
Maps values to specified colors in visualizations.
**This setting is deprecated and will not be supported as of 8.0.**
Maps values to specific colors in *Visualize* charts and *TSVB*. This setting does not apply to *Lens*.

[[visualization-dimmingopacity]]`visualization:dimmingOpacity`::
The opacity of the chart items that are dimmed when highlighting another element
Expand Down
12 changes: 11 additions & 1 deletion src/plugins/charts/server/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,18 @@ export class ChartsServerPlugin implements Plugin<object, object> {
}),
type: 'json',
description: i18n.translate('charts.advancedSettings.visualization.colorMappingText', {
defaultMessage: 'Maps values to specified colors within visualizations',
VladLasitsa marked this conversation as resolved.
Show resolved Hide resolved
defaultMessage:
'Maps values to specific colors in <strong>Visualize</strong> charts and <strong>TSVB</strong>. This setting does not apply to <strong>Lens.</strong>',
}),
deprecation: {
message: i18n.translate(
'charts.advancedSettings.visualization.colorMappingTextDeprecation',
{
defaultMessage: 'This setting is deprecated and will not be supported as of 8.0.',
}
),
docLinksKey: 'visualizationSettings',
},
category: ['visualization'],
schema: schema.string(),
},
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@
"apmOss.tutorial.startServer.title": "APM Server の起動",
"apmOss.tutorial.windowsServerInstructions.textPost": "注:システムでスクリプトの実行が無効な場合、スクリプトを実行するために現在のセッションの実行ポリシーの設定が必要となります。例: {command}。",
"apmOss.tutorial.windowsServerInstructions.textPre": "1.[ダウンロードページ]({downloadPageLink}) から APM Server Windows zip ファイルをダウンロードします。\n2.zip ファイルの内容を {zipFileExtractFolder} に抽出します。\n3.「{apmServerDirectory} ディレクトリの名前を「APM-Server」に変更します。\n4.管理者として PowerShell プロンプトを開きます (PowerShell アイコンを右クリックして「管理者として実行」を選択します)。Windows XP をご使用の場合、PowerShell のダウンロードとインストールが必要な場合があります。\n5.PowerShellプロンプトで次のコマンドを実行し、APM ServerをWindowsサービスとしてインストールします。",
"charts.advancedSettings.visualization.colorMappingText": "ビジュアライゼーション内の特定の色のマップ値です",
"charts.advancedSettings.visualization.colorMappingTitle": "カラーマッピング",
"charts.colormaps.bluesText": "青",
"charts.colormaps.greensText": "緑",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@
"apmOss.tutorial.startServer.title": "启动 APM Server",
"apmOss.tutorial.windowsServerInstructions.textPost": "注意：如果您的系统禁用了脚本执行，则需要为当前会话设置执行策略，以允许脚本运行。示例：{command}。",
"apmOss.tutorial.windowsServerInstructions.textPre": "1.从[下载页面]({downloadPageLink})下载 APM Server Windows zip 文件。\n2.将 zip 文件的内容解压缩到 {zipFileExtractFolder}。\n3.将 {apmServerDirectory} 目录重命名为 `APM-Server`。\n4.以管理员身份打开 PowerShell 提示符（右键单击 PowerShell 图标，然后选择**以管理员身份运行**）。如果您正在运行 Windows XP，您可能需要下载并安装 PowerShell。\n5.从 PowerShell 提示符处，运行以下命令以将 APM Server 安装为 Windows 服务：",
"charts.advancedSettings.visualization.colorMappingText": "将值映射到可视化内的指定颜色",
"charts.advancedSettings.visualization.colorMappingTitle": "颜色映射",
"charts.colormaps.bluesText": "蓝色",
"charts.colormaps.greensText": "绿色",
Expand Down