Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate visualization:colorMapping advanced setting #83372

Merged
merged 6 commits into from
Nov 23, 2020
Merged

Deprecate visualization:colorMapping advanced setting #83372

merged 6 commits into from
Nov 23, 2020

Conversation

VladLasitsa
Copy link
Contributor

@VladLasitsa VladLasitsa commented Nov 13, 2020 •
edited by stratoula
Loading

Closes: #82743

Summary

Added deprecation "This setting is deprecated and will not be supported as of 8.0. Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens." for visualization:colorMapping

Screenshot 2020-11-20 at 2 57 06 PM

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@VladLasitsa VladLasitsa requested a review from alexwizp November 13, 2020 10:12
alexwizp
alexwizp reviewed Nov 13, 2020
View reviewed changes
docs/management/advanced-options.asciidoc Outdated
@@ -454,6 +454,7 @@ of buckets to try to represent.

[horizontal]
[[visualization-colormapping]]`visualization:colorMapping`::
**Deprecated**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more informative message like e.g.

This setting is deprecated and will no longer be supported as of 8.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flash1293 do you think this is enough or should we add more details?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I would like to add a note here about this setting only applying to Visualize charts and TSVB (not Lens). @gchaps do you have an idea how to word this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the documentation, I'd use this wording:

This setting is deprecated and will not be supported as of 8.0. Maps values to specific colors in Visualize charts and TSVB. This setting does not apply to Lens.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated text for deprecation.

@VladLasitsa VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0 labels Nov 17, 2020
alexwizp
alexwizp approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: my concern is that @gchaps has highlighted some words. I'm not sure if this should be done for everything, but it's probably worth highlighting the words Visualize, TSVB, Lens

The rest code looks good to me

@VladLasitsa VladLasitsa marked this pull request as ready for review November 20, 2020 11:26
@VladLasitsa VladLasitsa requested a review from a team November 20, 2020 11:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula
Copy link
Contributor

stratoula commented Nov 20, 2020 •
edited
Loading

@VladLasitsa thanx for this PR. Can you please update the PR's description explaining what this PR does and add some screenshots? Thank you a ton.
Moreover, I am not sure about skipping the release note. I think that as it is a deprecation we should label it as release_note: deprecation.

@VladLasitsa VladLasitsa added release_note:deprecation and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 20, 2020
stratoula
stratoula approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested it locally, seems fine

@gtback
Copy link
Member

gtback commented Nov 20, 2020

@elasticmachine run elasticsearch-ci/docs

@gchaps
Copy link
Contributor

gchaps commented Nov 20, 2020

Text LGTM.

@VladLasitsa
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@VladLasitsa VladLasitsa merged commit 197b9dd into elastic:master Nov 23, 2020
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Nov 23, 2020
@VladLasitsa @kibanamachine
Deprecate visualization:colorMapping advanced setting (elastic#83372)
3b90c1e 
* Added deprecation for visualization:colorMapping

* Update text of deprecation

* Update message

* Delete from translations for re-translation

Co-authored-by: Kibana Machine <[email protected]>
@VladLasitsa VladLasitsa mentioned this pull request Nov 23, 2020
Merged
gmmorris added a commit to rudolf/kibana that referenced this pull request Nov 23, 2020
@gmmorris
Merge branch 'master' into pr/83866
0745518 
* master: (67 commits)
  [Observability] Load hasData call asynchronously (elastic#80644)
  Implement AnonymousAuthenticationProvider. (elastic#79985)
  Deprecate `visualization:colorMapping` advanced setting (elastic#83372)
  [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635)
  Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037)
  skip flaky suite (elastic#83772)
  skip flaky suite (elastic#69849)
  create kbn-legacy-logging package (elastic#77678)
  [Search] Search batching using bfetch (elastic#83418)
  [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033)
  Drop use of console-stamp (elastic#83922)
  skip flaky suite (elastic#84011 , elastic#84012)
  Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760)
  [maps] support URL drilldowns (elastic#83732)
  Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)"
  [code coverage] Update jest config to collect more data (elastic#83804)
  Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)
  [Security Solution] Give notice when endpoint policy is out of date (elastic#83469)
  [Security Solution] Sync url state on any changes to query string (elastic#83314)
  [CI] Initial TeamCity implementation (elastic#81043)
  ...
VladLasitsa added a commit that referenced this pull request Nov 24, 2020
@VladLasitsa @kibanamachine
Deprecate visualization:colorMapping advanced setting (#83372) (#84048
f1f0c9b 
)

* Added deprecation for visualization:colorMapping

* Update text of deprecation

* Update message

* Delete from translations for re-translation

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@lcawl lcawl mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@alexwizp alexwizp alexwizp approved these changes

@flash1293 flash1293 flash1293 left review comments

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
release_note:deprecation Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate visualization:colorMapping advanced setting
8 participants
@VladLasitsa @elasticmachine @stratoula @gtback @gchaps @kibanamachine @flash1293 @alexwizp