[ML] Functional tests - add basic license tests

x-pack/plugins/ml/public/application/components/navigation_menu/main_tabs.tsx

@@ -160,7 +160,12 @@ export const MainTabs: FC<Props> = ({ tabId, disableLinks }) => {
         const defaultPathId = (TAB_DATA[id].pathId || id) as MlUrlGeneratorState['page'];
 
         return disabled ? (
-          <EuiTab key={`${id}-key`} className={'mlNavigationMenu__mainTab'} disabled={true}>
+          <EuiTab
+            key={`${id}-key`}
+            className={'mlNavigationMenu__mainTab'}
+            disabled={true}
+            data-test-subj={testSubject}
+          >
             {tab.name}
           </EuiTab>
         ) : (

x-pack/plugins/ml/public/application/datavisualizer/datavisualizer_selector.tsx

@@ -189,13 +189,15 @@ export const DatavisualizerSelector: FC = () => {
                       <EuiButton
                         target="_blank"
                         href={`${basePath.get()}/app/management/stack/license_management/home`}
+                        data-test-subj="mlDataVisualizerStartTrialButton"
                       >
                         <FormattedMessage
                           id="xpack.ml.datavisualizer.selector.startTrialButtonLabel"
                           defaultMessage="Start trial"
                         />
                       </EuiButton>
                     }
+                    data-test-subj="mlDataVisualizerCardStartTrial"
                   />
                 </EuiFlexItem>
               </EuiFlexGroup>

x-pack/plugins/ml/public/application/routing/router.tsx

@@ -117,7 +117,7 @@ export const MlRouter: FC<{
   <Router history={pageDeps.history}>
     <LegacyHashUrlRedirect>
       <UrlStateProvider>
-        <div className="ml-app">
+        <div className="ml-app" data-test-subj="mlApp">
           <MlRoutes pageDeps={pageDeps} />
         </div>
       </UrlStateProvider>

x-pack/scripts/functional_tests.js

@@ -6,6 +6,7 @@
 
 const alwaysImportedTests = [
   require.resolve('../test/functional/config.js'),
+  require.resolve('../test/functional_basic/config.ts'),
   require.resolve('../test/security_solution_endpoint/config.ts'),
   require.resolve('../test/plugin_functional/config.ts'),
   require.resolve('../test/functional_with_es_ssl/config.ts'),
@@ -20,6 +21,7 @@ const onlyNotInCoverageTests = [
   require.resolve('../test/api_integration/config_security_basic.ts'),
   require.resolve('../test/api_integration/config_security_trial.ts'),
   require.resolve('../test/api_integration/config.ts'),
+  require.resolve('../test/api_integration_basic/config.ts'),
   require.resolve('../test/alerting_api_integration/basic/config.ts'),
   require.resolve('../test/alerting_api_integration/spaces_only/config.ts'),
   require.resolve('../test/alerting_api_integration/security_and_spaces/config.ts'),

x-pack/test/api_integration/apis/transform/index.ts

@@ -10,7 +10,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
   const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
-  describe('Machine Learning', function () {
+  describe('transform', function () {
     this.tags(['transform']);
 
     before(async () => {

x-pack/test/api_integration_basic/apis/index.ts

@@ -0,0 +1,16 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrProviderContext } from '../ftr_provider_context';
+
+export default function ({ loadTestFile }: FtrProviderContext) {
+  describe('apis', function () {
+    this.tags('ciGroup2');
+
+    loadTestFile(require.resolve('./ml'));
+    loadTestFile(require.resolve('./transform'));
+  });
+}

x-pack/test/api_integration_basic/apis/ml/data_visualizer/index.ts

@@ -0,0 +1,14 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrProviderContext } from '../../../ftr_provider_context';
+
+export default function ({ loadTestFile }: FtrProviderContext) {
+  describe('data visualizer', function () {
+    // The data visualizer APIs should work the same as with a trial license
+    loadTestFile(require.resolve('../../../../api_integration/apis/ml/data_visualizer'));
+  });
+}

x-pack/test/api_integration_basic/apis/ml/index.ts

@@ -0,0 +1,39 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ getService, loadTestFile }: FtrProviderContext) {
+  const esArchiver = getService('esArchiver');
+  const ml = getService('ml');
+
+  describe('machine learning basic license', function () {
+    this.tags(['mlqa']);
+
+    before(async () => {
+      await ml.securityCommon.createMlRoles();
+      await ml.securityCommon.createMlUsers();
+    });
+
+    after(async () => {
+      await ml.securityCommon.cleanMlUsers();
+      await ml.securityCommon.cleanMlRoles();
+
+      await ml.testResources.deleteIndexPatternByTitle('ft_farequote');
+
+      await esArchiver.unload('ml/farequote');
+
+      await ml.testResources.resetKibanaTimeZone();
+    });
+
+    loadTestFile(require.resolve('./data_visualizer'));
+  });
+}

x-pack/test/api_integration_basic/apis/transform/index.ts

@@ -0,0 +1,16 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrProviderContext } from '../../ftr_provider_context';
+
+export default function ({ loadTestFile }: FtrProviderContext) {
+  describe('transform basic license', function () {
+    this.tags(['transform']);
+
+    // The transform UI should work the same as with a trial license
+    loadTestFile(require.resolve('../../../api_integration/apis/transform'));
+  });
+}

x-pack/test/api_integration_basic/config.ts

@@ -0,0 +1,32 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrConfigProviderContext } from '@kbn/test/types/ftr';
+
+export default async function ({ readConfigFile }: FtrConfigProviderContext) {
+  const xpackApiIntegrationConfig = await readConfigFile(
+    require.resolve('../api_integration/config.ts')
+  );
+
+  return {
+    // default to the xpack api integration config
+    ...xpackApiIntegrationConfig.getAll(),
+    esTestCluster: {
+      ...xpackApiIntegrationConfig.get('esTestCluster'),
+      license: 'basic',
+      serverArgs: [
+        'xpack.license.self_generated.type=basic',
+        'xpack.security.enabled=true',
+        'xpack.security.authc.api_key.enabled=true',
+      ],
+    },
+    testFiles: [require.resolve('./apis')],
+    junit: {
+      ...xpackApiIntegrationConfig.get('junit'),
+      reportName: 'Chrome X-Pack UI Functional Tests Basic License',
+    },
+  };
+}

x-pack/test/api_integration_basic/ftr_provider_context.d.ts

@@ -0,0 +1,11 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { GenericFtrProviderContext } from '@kbn/test/types/ftr';
+
+import { services } from '../api_integration/services';
+
+export type FtrProviderContext = GenericFtrProviderContext<typeof services, {}>;

x-pack/test/functional/apps/ml/data_visualizer/index.ts

@@ -10,6 +10,7 @@ export default function ({ loadTestFile }: FtrProviderContext) {
     this.tags(['skipFirefox']);
 
     loadTestFile(require.resolve('./index_data_visualizer'));
+    loadTestFile(require.resolve('./index_data_visualizer_actions_panel'));
     loadTestFile(require.resolve('./file_data_visualizer'));
   });
 }

x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer.ts

@@ -11,7 +11,6 @@ import { FieldVisConfig } from '../../../../../plugins/ml/public/application/dat
 interface TestData {
   suiteTitle: string;
   sourceIndexOrSavedSearch: string;
-  advancedJobWizardDatafeedQuery: string;
   metricFieldsFilter: string;
   nonMetricFieldsFilter: string;
   nonMetricFieldsTypeFilter: string;
@@ -45,15 +44,6 @@ export default function ({ getService }: FtrProviderContext) {
   const farequoteIndexPatternTestData: TestData = {
     suiteTitle: 'index pattern',
     sourceIndexOrSavedSearch: 'ft_farequote',
-    advancedJobWizardDatafeedQuery: `{
-  "bool": {
-    "must": [
-      {
-        "match_all": {}
-      }
-    ]
-  }
-}`,
     metricFieldsFilter: 'document',
     nonMetricFieldsFilter: 'airline',
     nonMetricFieldsTypeFilter: 'keyword',
@@ -128,15 +118,6 @@ export default function ({ getService }: FtrProviderContext) {
   const farequoteKQLSearchTestData: TestData = {
     suiteTitle: 'KQL saved search',
     sourceIndexOrSavedSearch: 'ft_farequote_kuery',
-    advancedJobWizardDatafeedQuery: `{
-  "bool": {
-    "must": [
-      {
-        "match_all": {}
-      }
-    ]
-  }
-}`, // Note query is not currently passed to the wizard
     metricFieldsFilter: 'responsetime',
     nonMetricFieldsFilter: 'airline',
     nonMetricFieldsTypeFilter: 'keyword',
@@ -211,15 +192,6 @@ export default function ({ getService }: FtrProviderContext) {
   const farequoteLuceneSearchTestData: TestData = {
     suiteTitle: 'lucene saved search',
     sourceIndexOrSavedSearch: 'ft_farequote_lucene',
-    advancedJobWizardDatafeedQuery: `{
-  "bool": {
-    "must": [
-      {
-        "match_all": {}
-      }
-    ]
-  }
-}`, // Note query is not currently passed to the wizard
     metricFieldsFilter: 'responsetime',
     nonMetricFieldsFilter: 'version',
     nonMetricFieldsTypeFilter: 'keyword',
@@ -425,17 +397,6 @@ export default function ({ getService }: FtrProviderContext) {
       });
 
       runTests(farequoteLuceneSearchTestData);
-
-      // Test the Create advanced job button.
-      // Note the search is not currently passed to the wizard, just the index.
-      it(`${farequoteLuceneSearchTestData.suiteTitle} opens the advanced job wizard`, async () => {
-        await ml.dataVisualizerIndexBased.clickCreateAdvancedJobButton();
-        await ml.jobTypeSelection.assertAdvancedJobWizardOpen();
-        await ml.jobWizardAdvanced.assertDatafeedQueryEditorExists();
-        await ml.jobWizardAdvanced.assertDatafeedQueryEditorValue(
-          farequoteLuceneSearchTestData.advancedJobWizardDatafeedQuery
-        );
-      });
     });
   });
 }

x-pack/test/functional/apps/ml/data_visualizer/index_data_visualizer_actions_panel.ts

@@ -0,0 +1,62 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { FtrProviderContext } from '../../../ftr_provider_context';
+
+export default function ({ getService }: FtrProviderContext) {
+  const esArchiver = getService('esArchiver');
+  const ml = getService('ml');
+
+  describe('index based actions panel', function () {
+    this.tags(['mlqa']);
+
+    const indexPatternName = 'ft_farequote';
+    const advancedJobWizardDatafeedQuery = `{
+  "bool": {
+    "must": [
+      {
+        "match_all": {}
+      }
+    ]
+  }
+}`; // Note query is not currently passed to the wizard
+
+    before(async () => {
+      await esArchiver.loadIfNeeded('ml/farequote');
+      await ml.testResources.createIndexPatternIfNeeded(indexPatternName, '@timestamp');
+      await ml.testResources.setKibanaTimeZoneToUTC();
+
+      await ml.securityUI.loginAsMlPowerUser();
+    });
+
+    describe('create advanced job action', function () {
+      it('loads the source data in the data visualizer', async () => {
+        await ml.testExecution.logTestStep('loads the data visualizer selector page');
+        await ml.navigation.navigateToMl();
+        await ml.navigation.navigateToDataVisualizer();
+
+        await ml.testExecution.logTestStep('loads the saved search selection page');
+        await ml.dataVisualizer.navigateToIndexPatternSelection();
+
+        await ml.testExecution.logTestStep('loads the index data visualizer page');
+        await ml.jobSourceSelection.selectSourceForIndexBasedDataVisualizer(indexPatternName);
+      });
+
+      it('opens the advanced job wizard', async () => {
+        await ml.testExecution.logTestStep('displays the actions panel with advanced job card');
+        await ml.dataVisualizerIndexBased.assertActionsPanelExists();
+        await ml.dataVisualizerIndexBased.assertCreateAdvancedJobCardExists();
+
+        // Note the search is not currently passed to the wizard, just the index.
+        await ml.testExecution.logTestStep('displays the actions panel with advanced job card');
+        await ml.dataVisualizerIndexBased.clickCreateAdvancedJobButton();
+        await ml.jobTypeSelection.assertAdvancedJobWizardOpen();
+        await ml.jobWizardAdvanced.assertDatafeedQueryEditorExists();
+        await ml.jobWizardAdvanced.assertDatafeedQueryEditorValue(advancedJobWizardDatafeedQuery);
+      });
+    });
+  });
+}

x-pack/test/functional/apps/ml/permissions/full_ml_access.ts

@@ -47,9 +47,32 @@ export default function ({ getService }: FtrProviderContext) {
             await ml.navigation.assertKibanaNavMLEntryExists();
           });
 
+          it('should display tabs in the ML app correctly', async () => {
+            await ml.testExecution.logTestStep('should load the ML app');
+            await ml.navigation.navigateToMl();
+
+            await ml.testExecution.logTestStep('should display the enabled "Overview" tab');
+            await ml.navigation.assertOverviewTabEnabled(true);
+
+            await ml.testExecution.logTestStep(
+              'should display the enabled "Anomaly Detection" tab'
+            );
+            await ml.navigation.assertAnomalyDetectionTabEnabled(true);
+
+            await ml.testExecution.logTestStep(
+              'should display the enabled "Data Frame Analytics" tab'
+            );
+            await ml.navigation.assertDataFrameAnalyticsTabEnabled(true);
+
+            await ml.testExecution.logTestStep('should display the enabled "Data Visualizer" tab');
+            await ml.navigation.assertDataVisualizerTabEnabled(true);
+
+            await ml.testExecution.logTestStep('should display the enabled "Settings" tab');
+            await ml.navigation.assertSettingsTabEnabled(true);
+          });
+
           it('should display elements on ML Overview page correctly', async () => {
             await ml.testExecution.logTestStep('should load the ML overview page');
-            await ml.navigation.navigateToMl();
             await ml.navigation.navigateToOverview();
 
             await ml.testExecution.logTestStep('should display enabled AD create job button');
@@ -353,7 +376,7 @@ export default function ({ getService }: FtrProviderContext) {
             await ml.dataVisualizerFileBased.selectFile(uploadFilePath);
 
             await ml.testExecution.logTestStep(
-              'should displays components of the file details page'
+              'should display components of the file details page'
             );
             await ml.dataVisualizerFileBased.assertFileTitle(expectedUploadFileTitle);
             await ml.dataVisualizerFileBased.assertFileContentPanelExists();