-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Functional tests - add basic license tests #82147
Conversation
Pinging @elastic/ml-ui (:ml) |
Checking test stability in a flaky test runner job ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just spotted a few typos
x-pack/test/functional_basic/apps/ml/permissions/no_ml_access.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional_basic/apps/ml/permissions/no_ml_access.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional_basic/apps/ml/permissions/full_ml_access.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional_basic/apps/ml/permissions/read_ml_access.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted another couple of typos
x-pack/test/functional_basic/apps/ml/permissions/full_ml_access.ts
Outdated
Show resolved
Hide resolved
x-pack/test/functional_basic/apps/ml/permissions/read_ml_access.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these basic license tests in! Tested locally and LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds initial functional tests and api integration tests running on a basic license for the ML and Transform apps.
Summary
This PR adds initial functional tests and api integration tests running on a basic license for the ML and Transform apps.
Details
Directory structure / CI
As discussed with @spalger and @dmlemeshko, in
x-pack/test
there are now two new directories:api_integration_basic
andfunctional_basic
that reuse esArchives, services, pageObjects and configs fromapi_integration
andfunctional
respectively, basically just overriding the license and the test report name. This way it's easy to reuse in case other apps want to add basic license tests as well in the future without the overhead of additional configs.The new directories are added to the
functional_tests
script file and the suites will run inciGroup2
for now (since as of writing this, that group has the shortest runtime).Added basic license tests
Some existing (trial license) test files are included for the features that should work the same on a basic license.
ML:
api_integration_basic
data_visualizer
testsfunctional_basic
data_visualizer
tests with the exception of the advanced job wizard test, see below inOther changes
permission
tests similar to the existing (trial license) ones, but adjusted for validating the UI on basic licenseTransform:
api_integration
andfunctional
tests are included and nothing is added.Other changes
open advanced wizard
test to a separate test file to make the rest of the tests reusable for basic licensemlApp
to exist.Run the tests
From the
x-pack
directory runfor the functional basic license tests or
for the api integration basic license tests.