-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log reason for 404 in field existence check #81315
Merged
flash1293
merged 5 commits into
elastic:master
from
flash1293:lens/log-existing-field-reason
Oct 27, 2020
Merged
Log reason for 404 in field existence check #81315
flash1293
merged 5 commits into
elastic:master
from
flash1293:lens/log-existing-field-reason
Oct 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
v8.0.0
labels
Oct 21, 2020
flash1293
added
the
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
label
Oct 22, 2020
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, did not test it locally though
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 27, 2020
This was referenced Oct 27, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 27, 2020
* master: [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) [Lens] Fix URL query loss on redirect (elastic#81475) Log reason for 404 in field existence check (elastic#81315)
flash1293
added a commit
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Lens
release_note:skip
Skip the PR/issue when compiling release notes
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #77567
This PR forwards the reason of a failed existence check to the client as part of the error message (helpful for debugging in a lot of cases).
It also makes sure this message is logged in the functional test to get the reason for the failure.
If the request fails, it will get logged in the build: