[Task Manager] Mark task as failed if maxAttempts has been met. #80681

ymao1 · 2020-10-15T15:16:11Z

Resolves #79165

Summary

Uses updateByQuery to mark non-recurring tasks that have exceeded its maxAttempts as failed instead of leaving them in a running state.

Previously, query portion of the updateByQuery included a clause that searched for tasks with a schedule or tasks where attempts < maxAttempts. Moved this check from the query into the painless script. Tasks that don't meet this condition (non-recurring tasks that have exceeded its maxAttempts) are updated to failed while other tasks are claimed as normal.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.ts

x-pack/plugins/task_manager/server/task_store.ts

…manager/mark-task-as-failed

…empts

elasticmachine · 2020-10-21T11:58:37Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1 · 2020-10-26T12:50:37Z

@elasticmachine merge upstream

mikecote

Changes LGTM! Tried it locally and I can see the tasks marked as failed whenever retryAt is passed and attempts exceeds the configuration 👍

x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.ts

mikecote · 2020-10-26T13:27:33Z

x-pack/plugins/task_manager/server/task_store.ts

-      shouldBeOneOf<ExistsFilter | TermFilter | RangeFilter>(
-        TaskWithSchedule,
-        ...tasksWithRemainingAttempts
-      )


❤️ this is going to make the query soo much smaller

:elasticheart:

YulNaumenko

LGTM

YulNaumenko · 2020-10-26T04:33:48Z

x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.test.ts

@@ -40,29 +31,29 @@ describe('mark_available_tasks_as_claimed', () => {
        createTaskRunner: () => ({ run: () => Promise.resolve() }),
      },
    });
+    const claimTasksById = undefined;


nit: I think it could be just array of strings like:
const claimTasksById: string[] = [];

kibanamachine · 2020-10-26T16:12:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ac61133

Metrics [docs]

✅ unchanged

History

💚 Build #83626 succeeded 8a41d26
💚 Build #83381 succeeded 7b4388c
💚 Build #82963 succeeded 24f3420
💔 Build #82896 failed 877319f
💔 Build #82754 failed 6445a72

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris

Whoop whoop, works as expected, good job 👍

…tic#80681) * wip * Adding updateFieldsAndMarkAsFailed function * Updating UBQ * Only updating retryAt if marking as claiming * Updating query * Updating query to only fail one time tasks that have exceeded max attempts * Fixing tests * Fixing tests * Handling claiming tasks by id * Removing unused function Co-authored-by: Kibana Machine <[email protected]>

…) (#81750) * wip * Adding updateFieldsAndMarkAsFailed function * Updating UBQ * Only updating retryAt if marking as claiming * Updating query * Updating query to only fail one time tasks that have exceeded max attempts * Fixing tests * Fixing tests * Handling claiming tasks by id * Removing unused function Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

* master: [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) [Lens] Fix URL query loss on redirect (elastic#81475) Log reason for 404 in field existence check (elastic#81315)

* master: (87 commits) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81778) [i18n] add get_kibana_translation_paths tests (elastic#81624) [UX] Fix search term reset from url (elastic#81654) [Lens] Improved range formatter (elastic#80132) [Resolver] `SideEffectContext` changes, remove `@testing-library` uses (elastic#81077) [Time to Visualize] Update Library Text with Call to Action (elastic#81667) [docs] Resolving failed Kibana upgrade migrations (elastic#80999) [ftr/menuToggle] provide helper for enhanced menu toggle handling (elastic#81709) [Task Manager] adds basic observability into Task Manager's runtime operations (elastic#77868) Doc changes for stack management and grouped feature privileges (elastic#80486) Added functional test for alerts list filters by status, alert type and action type. Did a code refactoring and splitting for alerts tests. (elastic#81422) [Security Solution][Endpoint][Admin] Malware Protections Notify User Version (elastic#81415) Revert "[Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390)" [Maps] Use default format when proxying EMS-files (elastic#79760) [Discover] Deangularize context.html (elastic#81442) Use the displayName property in default editor (elastic#73311) adds bug label to Bug report for Security Solution template (elastic#81643) [ML] Transforms: Remove index field limitation for custom query. (elastic#81467) [Actions] Adding `hasAuth` to Webhook Configuration to avoid confusing UX (elastic#81390) [Task Manager] Mark task as failed if maxAttempts has been met. (elastic#80681) ...

ymao1 added 4 commits October 13, 2020 15:08

wip

5cc5c8e

Adding updateFieldsAndMarkAsFailed function

14c2a3f

Updating UBQ

a1d589d

Only updating retryAt if marking as claiming

eaf7c87

ymao1 requested a review from gmmorris October 15, 2020 15:16

Updating query

4d527e7

gmmorris reviewed Oct 19, 2020

View reviewed changes

x-pack/plugins/task_manager/server/queries/mark_available_tasks_as_claimed.ts Outdated Show resolved Hide resolved

gmmorris reviewed Oct 19, 2020

View reviewed changes

x-pack/plugins/task_manager/server/task_store.ts Outdated Show resolved Hide resolved

ymao1 added 6 commits October 20, 2020 07:56

Merge branch 'master' of https://github.com/elastic/kibana into task-…

57c232d

…manager/mark-task-as-failed

Merging in master

6445a72

Updating query to only fail one time tasks that have exceeded max att…

877319f

…empts

Fixing tests

1cc6725

Fixing tests

f5a19e3

Handling claiming tasks by id

24f3420

ymao1 changed the title ~~Task manager/mark task as failed~~ [Task Manager] Mark task as failed if maxAttempts has been met. Oct 21, 2020

ymao1 added Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0 labels Oct 21, 2020

ymao1 marked this pull request as ready for review October 21, 2020 11:58

ymao1 requested a review from a team as a code owner October 21, 2020 11:58

ymao1 self-assigned this Oct 21, 2020

Merging in master

7b4388c

Merge branch 'master' into task-manager/mark-task-as-failed

8a41d26

mikecote self-requested a review October 26, 2020 12:57

mikecote approved these changes Oct 26, 2020

View reviewed changes

Removing unused function

ac61133

YulNaumenko approved these changes Oct 26, 2020

View reviewed changes

gmmorris approved these changes Oct 27, 2020

View reviewed changes

ymao1 merged commit e6ab812 into elastic:master Oct 27, 2020

ymao1 mentioned this pull request Oct 27, 2020

[7.x] [Task Manager] Mark task as failed if maxAttempts has been met. (#80681) #81750

Merged

gmmorris mentioned this pull request Nov 23, 2020

Tasks of removed types cause script errors #84088

Closed

mikecote added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Dec 16, 2020

ymao1 deleted the task-manager/mark-task-as-failed branch February 4, 2021 15:25

ymao1 mentioned this pull request Nov 3, 2021

[alerting] rule tasks that fail 3 times are never run again, with no indication in the rule #116321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Task Manager] Mark task as failed if maxAttempts has been met. #80681

[Task Manager] Mark task as failed if maxAttempts has been met. #80681

ymao1 commented Oct 15, 2020 •

edited

Loading

elasticmachine commented Oct 21, 2020

ymao1 commented Oct 26, 2020

mikecote left a comment

mikecote Oct 26, 2020

gmmorris Oct 27, 2020

YulNaumenko left a comment

YulNaumenko Oct 26, 2020

kibanamachine commented Oct 26, 2020

gmmorris left a comment

[Task Manager] Mark task as failed if maxAttempts has been met. #80681

[Task Manager] Mark task as failed if maxAttempts has been met. #80681

Conversation

ymao1 commented Oct 15, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Oct 21, 2020

ymao1 commented Oct 26, 2020

mikecote left a comment

Choose a reason for hiding this comment

mikecote Oct 26, 2020

Choose a reason for hiding this comment

gmmorris Oct 27, 2020

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

YulNaumenko Oct 26, 2020

Choose a reason for hiding this comment

kibanamachine commented Oct 26, 2020

💚 Build Succeeded

Metrics [docs]

History

gmmorris left a comment

Choose a reason for hiding this comment

ymao1 commented Oct 15, 2020 •

edited

Loading