Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dumb-init to tini in Kibana Docker image #81126

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

mieciu
Copy link
Contributor

@mieciu mieciu commented Oct 20, 2020

Summary

This PR changes Docker container init system from dumb-init to tini.

Main goal behind this change is to align with Elasticsearch Docker image. Eventually, all stack component containers should use the same init system.

Created a simple test environment with Elasticsearch snapshot image:

docker run -i -t -p 9200:9200 --net kibana-test -e "discovery.type=single-node" docker.elastic.co/elasticsearch/elasticsearch:8.0.0-SNAPSHOT
docker run -i -t --net kibana-test --link dedd4543e33e:elasticsearch -p 5601:5601 docker.elastic.co/kibana/kibana:8.0.0-SNAPSHOT

image

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mieciu mieciu marked this pull request as ready for review October 21, 2020 06:00
@mieciu mieciu requested a review from a team as a code owner October 21, 2020 06:00
@spalger spalger requested a review from tylersmalley October 21, 2020 15:41
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0 labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley tylersmalley merged commit 5cb7e81 into elastic:master Oct 21, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Oct 21, 2020
@tylersmalley
Copy link
Contributor

Thanks @mieciu! Backport is here: #81401

tylersmalley pushed a commit that referenced this pull request Oct 21, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 22, 2020
* master: (63 commits)
  [KP] Fix Headers timeout issue (elastic#81140)
  [ML] Functional tests - stabilize typing with checks service method (elastic#81338)
  tabify - support docs (elastic#80351)
  [Security Solution][Detections] Look-back time logic fix (elastic#81383)
  [Workplace Search] Add top-level tests for Groups (elastic#81215)
  [Fleet] Fix agent action observable for long polling (elastic#81376)
  [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373)
  skip flaky suite (elastic#78689)
  chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357)
  Ensure some data is returned (elastic#81375)
  Change dumb-init to tini (elastic#81126)
  [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242)
  Use Storybook Controls instead of Knobs (elastic#80705)
  [junit] make sure that report paths are unique (elastic#81255)
  bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288)
  run ssl tests on CI (elastic#81320)
  Fix alert defaults (elastic#81207)
  [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078)
  Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657)
  [Monitoring] Use async/await (elastic#81200)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants