[ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate #81078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
...ata_frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
Outdated
Show resolved
Hide resolved
...ata_frame_analytics/pages/analytics_creation/components/advanced_step/advanced_step_form.tsx
Outdated
Show resolved
Hide resolved
|
This has been updated and is ready for a final look when you get a chance. 🙏 cc @peteharverson, @walterra, @qn895 |
qn895
reviewed
Oct 21, 2020
| <EuiSwitch | ||
| disabled={isJobCreated} | ||
| name="mlDataFrameAnalyticsUseEstimatedMml" | ||
| label={i18n.translate('xpack.ml.dataframe.analytics.create.UseEstimatedMmlLabel', { |
There was a problem hiding this comment.
super duper nit: create.useEstimatedMmlLabel here to match the convention
There was a problem hiding this comment.
Updated in 66bcffa
👍 😄
peteharverson
approved these changes
Oct 21, 2020
qn895
approved these changes
Oct 21, 2020
|
LGTM 🎉 |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 22, 2020
* master: (63 commits) [KP] Fix Headers timeout issue (elastic#81140) [ML] Functional tests - stabilize typing with checks service method (elastic#81338) tabify - support docs (elastic#80351) [Security Solution][Detections] Look-back time logic fix (elastic#81383) [Workplace Search] Add top-level tests for Groups (elastic#81215) [Fleet] Fix agent action observable for long polling (elastic#81376) [Maps] fix feature tooltip remains open when zoom level change hides layer (elastic#81373) skip flaky suite (elastic#78689) chore(NA): add spec-to-console and plugin-helpers as devOnly dependencies (elastic#81357) Ensure some data is returned (elastic#81375) Change dumb-init to tini (elastic#81126) [Reporting/Tech Debt] Convert PdfMaker class to TypeScript (elastic#81242) Use Storybook Controls instead of Knobs (elastic#80705) [junit] make sure that report paths are unique (elastic#81255) bump elastic/elasticsearch-js version to 7.10.0-rc1 (elastic#81288) run ssl tests on CI (elastic#81320) Fix alert defaults (elastic#81207) [ML] DF Analytics wizard: ensure user can set mml manually or select to use given estimate (elastic#81078) Add UI notifier to indicate secret fields and to remember / reenter values (elastic#80657) [Monitoring] Use async/await (elastic#81200) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: #80530
Move the model memory limit setting in the creation wizard behind a
Use estimated model memory limitswitch.If the user turns the switch to off, warning text including the given estimate is shown but the user can continue with the manually input value.
Checklist
Delete any items that are not applicable to this PR.