-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fix the Field dropdown in Timeline data providers… #80718
Merged
patrykkopycinski
merged 1 commit into
elastic:master
from
patrykkopycinski:fix/data-provider-field-options
Oct 15, 2020
Merged
[Security Solution] Fix the Field dropdown in Timeline data providers… #80718
patrykkopycinski
merged 1 commit into
elastic:master
from
patrykkopycinski:fix/data-provider-field-options
Oct 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resets when scrolled
patrykkopycinski
added
bug
Fixes for quality problems that affect the customer experience
Team:SIEM
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
labels
Oct 15, 2020
Pinging @elastic/kibana-security (Team:Security Solution) |
Pinging @elastic/siem (Team:SIEM) |
bkimmel
reviewed
Oct 15, 2020
x-pack/plugins/security_solution/public/timelines/components/edit_data_provider/index.tsx
Show resolved
Hide resolved
patrykkopycinski
removed
the
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
label
Oct 15, 2020
bkimmel
approved these changes
Oct 15, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 15, 2020
… resets when scrolled (elastic#80718)
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 15, 2020
… resets when scrolled (elastic#80718)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 16, 2020
* master: (115 commits) [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618) added brace import to vis editor (elastic#80652) Fix error rate sorting in services list (elastic#80764) Emit info log when using custom registry URL (elastic#80768) [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766) Add Storybook a11y addon (elastic#80069) Fix anomaly alert selection text (elastic#80746) [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208) [kbn/optimizer] tweak split chunks options (elastic#80444) update template to use the new team label (elastic#80748) [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718) Adjusts observability alerting perms to require "all" (elastic#79896) [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists (elastic#80592) [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612) Licensed feature usage for connectors (elastic#77679) [Security Solution] Cypress template creation (elastic#80180) [APM] Hide service if only data is from ML (elastic#80145) Fix role mappings test for ESS (elastic#80604) [Maps] Add support for envelope (elastic#80614) [Security Solution] Update button text according to status (elastic#80389) ...
MindyRS
added
the
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
label
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:SIEM
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… resets when scrolled
Summary
Fixes
As reported by @spong , in
master
, theField
dropdown in Timeline data providers resets when scrolled, per the screenshot in the Screenshots section below.This is not reproducible in
7.9.2
, but should be fixed before it ships in7.10
To Reproduce
Open timeline
In the drop area, click the
+ Add field
buttonType the text
host
in theField
dropdownScroll the dropdown with the mouse wheel
Expected result
Field
dropdown scrolls without resetting to the top scroll positionActual result
Screenshots
Desktop
master
as of Oct 8, 2020