Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Cypress template creation #80180

Merged
merged 24 commits into from
Oct 15, 2020
Merged

[Security Solution] Cypress template creation #80180

merged 24 commits into from
Oct 15, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Oct 12, 2020 •
edited
Loading

Summary

This PR is to fix the failing cypress test for template creation:
#79967
#79389

@angorayc
init tests
8a638a5
@angorayc
Merge branch 'master' of github.com:elastic/kibana
897eda1
@angorayc
Merge branch 'master' of github.com:elastic/kibana
6508784
@angorayc
Merge branch 'master' of github.com:elastic/kibana
79d5acb
@angorayc
Merge branch 'master' of github.com:elastic/kibana
564ae4b
@angorayc
Merge branch 'master' of github.com:elastic/kibana
e038b0b
@angorayc
Merge branch 'master' of github.com:elastic/kibana
b8b26e6
@angorayc
Merge branch 'master' of github.com:elastic/kibana
62207c4
@angorayc
Merge branch 'master' of github.com:elastic/kibana
85bfbf5
@angorayc
Merge branch 'master' of github.com:elastic/kibana
b91fd31
@angorayc
Merge branch 'master' of github.com:elastic/kibana
04ff349
@angorayc
Merge branch 'master' of github.com:elastic/kibana
e38ddab
@angorayc
Merge branch 'master' of github.com:elastic/kibana
bb498df
@angorayc
Merge branch 'master' of github.com:elastic/kibana
9b97a3b
@angorayc
Merge branch 'master' of github.com:elastic/kibana
974b938
@angorayc
Merge branch 'master' of github.com:elastic/kibana
c9adb27
@angorayc
Merge branch 'master' of github.com:elastic/kibana
f3d1379
@angorayc
fix cypress test
7379237
@angorayc
remove console
ccde582
@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 13, 2020
@angorayc angorayc marked this pull request as ready for review October 14, 2020 15:11
@angorayc angorayc requested review from a team as code owners October 14, 2020 15:11
@angorayc angorayc added the Team:Threat Hunting Security Solution Threat Hunting Team label Oct 14, 2020
@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

MadameSheema
MadameSheema requested changes Oct 15, 2020
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we cannot delete that methods because if not, we are not properly testing all the things we need.

@angorayc
Copy link
Contributor Author

filter
@MadameSheema I found that when adding a new filter to timeline without selecting from the suggestion list, the operation field remains disabled sometimes, so I guess that's why the timeline creation test failed occasionally because of that.
Therefor I'm changing the behaviour of adding the query field here:

kibana/x-pack/plugins/security_solution/cypress/tasks/timeline.ts

Line 74 in fbb4634

cy.get(TIMELINE_FILTER_FIELD).type(`${filter.field}{downarrow}{enter}`);

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MadameSheema
MadameSheema approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thanks for fixing this @angorayc :)

@angorayc angorayc merged commit 8d053fd into elastic:master Oct 15, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Oct 15, 2020
@angorayc @kibanamachine
[Security Solution] Cypress template creation (elastic#80180)
4b92d89 
* init tests

* fix cypress test

* remove console

* fix functional test

* update functional test

Co-authored-by: Kibana Machine <[email protected]>
@angorayc angorayc mentioned this pull request Oct 15, 2020
Merged
angorayc added a commit to angorayc/kibana that referenced this pull request Oct 15, 2020
@angorayc @kibanamachine
[Security Solution] Cypress template creation (elastic#80180)
0819cea 
* init tests

* fix cypress test

* remove console

* fix functional test

* update functional test

Co-authored-by: Kibana Machine <[email protected]>
@angorayc angorayc mentioned this pull request Oct 15, 2020
Merged
angorayc added a commit that referenced this pull request Oct 15, 2020
@angorayc @kibanamachine
[Security Solution] Cypress template creation (#80180) (#80728)
5a38aa5 
* init tests

* fix cypress test

* remove console

* fix functional test

* update functional test

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
angorayc added a commit that referenced this pull request Oct 15, 2020
@angorayc @kibanamachine
[Security Solution] Cypress template creation (#80180) (#80727)
22be615 
* init tests

* fix cypress test

* remove console

* fix functional test

* update functional test

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
475d49d 
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadameSheema MadameSheema MadameSheema approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@angorayc @kibanamachine @MadameSheema